-
Notifications
You must be signed in to change notification settings - Fork 1.9k
[DAT-17993] Improve diffChangelog between MSSQL and Oracle #6094
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…d to extract and compare it we need number too.
…cle vs Oracle comparisons
...ard/src/main/java/liquibase/diff/output/changelog/core/ChangedPrimaryKeyChangeGenerator.java
Outdated
Show resolved
Hide resolved
Are there any tests which cover these changes? If not, can one or some be added? |
* fix: integers don't have size on mssql * fix: Internally Oracle converts int/integer to number, so when we need to extract and compare it we need number too. * feat: add column name correction + some code reuse * chore: handle nullpointer * fix: as only oracle supports PK validate, we will use it only for Oracle vs Oracle comparisons * chore: refactoring to use constants * chore: include files in internal/lib folder --------- Co-authored-by: filipe <flautert@liquibase.com> Co-authored-by: obovsunivskyii <baqaua@gmail.com>
@filipelautert Hi, Filipe, I've recently switched to liquibase-core 4.29.2 from 4.27.0 in my project and found that Oracle diff calculation is broken because of changes in this pull reuqest, especially because of this implementation of
This method automatically converts all column names that starts from int*, like "internalPhoneNumber" to "NUMBER(*, 0)" and brakes Metadata comparison so diff generation is incorrect. Exact thing is I might be wrong, but this looks like bug to me. Could you or someone from the team help me to clarify that, please? |
Uh oh!
There was an error while loading. Please reload this page.