Support compression of returned content when served via HTTPS #147
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Awesome. Thank you!! |
|
My pleasure, thanks for maintaining this project! |
Merged
madskristensen
pushed a commit
that referenced
this pull request
Nov 29, 2021
Added edge case considerations for when including response compression as included in the feature #147, to allow for the end user to understand how to make sure that it compresses the responses and function correctly when utilized with this library.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When serving static files the
StaticFileMiddlewaresets HTTPS compression allowed by default as it's static content and not affected of CRIME/BREACH attacks which rely on attacker modifying returned payload. AsAssetMiddlewarebasically can be compared toStaticFileMiddlewareit makes sense to allow the same logic for response compression.I've adapted the approach
StaticFileMiddlewareuses and now also WebOptimizer content is compressed when served via HTTPS. The configuration option defaults and is documented the same way asStaticFileMiddlewareversion.