Align PLAYER_EVENT naming #526
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I think this change is a worthwhile one, will refrain from merging for now until just before we push the next release. |
This was referenced Mar 30, 2021
Gadgetoid
added a commit
to pimoroni/pidi-spotify
that referenced
this pull request
Mar 30, 2021
The valid event names in PLAYER_EVENT will change prior to v0.1.6 of librespot: librespot-org/librespot#526 * `change` will be `changed` * `start` will be `started` * `stop` will be `stopped` Functions have been renamed to support this anticipated change, and appropriate aliases added for back-compat.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm not sure if this is worth the breaking change, it just turned out be hard to align ENV names in spotifyd.
src/process.rsto this as naming was not consistent with the enum names. If there is some changelog I assume it would be good to explicitly mention this as beaking change if it is merged.