-
Notifications
You must be signed in to change notification settings - Fork 293
update certificate test vectors #665
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
What did you use for the issuer and subject fields? How did you generate these? |
certificates where generated with valid certificate details below:
for invalid certificate test case, i have generate certificate using the same method, but slightly modified code which generates different key used to sign the message (
|
also here is the comment in @MarcoPolo, please let me know your feedback. |
Is it possible to make the generating code deterministic (even if you have to hard code the private keys)? If so it would be useful to include here or in the appendix so we have it for reference. |
@MarcoPolo not really... well, technically it would be possible to have some code that deterministically generate certificates, but not with the way i have generated (just called i can paste this generating program here, for future reference, but why would it really need to be deterministic? |
here is the program that will deterministically generate certificates https://github.com/vladopajic/libp2p-cert-generator. output is this:
|
@MarcoPolo please let me know your feedback. i'll update information in spec once it is confirmed that certificates are correct. PRs in go and nim implementations are updated and passing tests. |
@MarcoPolo hey, any feedback on this? |
Will take a look at this today, apologies for the delay |
Looks good. Thank you for tidying this up. Ping me when you update the text in the tls spec |
certificate from test vectors don't have
issuer
andsubject
fields defined which can cause libraries, like MbedTLS, to fail to parse a certificate. issue documented here: #635this PR updates test vectors to have certificates with valid
issuer
andsubject
fields.PRs updating test vectors in implementation:
^ both PRs serve as showcase that certificate values, for test vectors, are correct (passing tests).