Skip to content

Conversation

vladopajic
Copy link
Contributor

@vladopajic vladopajic commented Mar 19, 2025

certificate from test vectors don't have issuer and subject fields defined which can cause libraries, like MbedTLS, to fail to parse a certificate. issue documented here: #635

this PR updates test vectors to have certificates with valid issuer and subject fields.

PRs updating test vectors in implementation:

^ both PRs serve as showcase that certificate values, for test vectors, are correct (passing tests).

@MarcoPolo
Copy link
Contributor

What did you use for the issuer and subject fields? How did you generate these?

@vladopajic
Copy link
Contributor Author

vladopajic commented Mar 20, 2025

certificates where generated with go-libp2p function libp2ptls.NewIdentity(priv).

valid certificate details below:

====== ECDSA Peer:
Peer ID: Qmf5QwyriEdqphhFWkFJsmfY4Sgsj5Cq47VTa5RAboELhM
Cert hex:
308201f63082019ca00302010202081052b953fab8f4be300a06082a8648ce3d040302301e311c301a06035504051313313931333134363939343730373431363038313020170d3235303332303130333033305a180f32313235303232343131333033305a301e311c301a06035504051313313931333134363939343730373431363038313059301306072a8648ce3d020106082a8648ce3d03010703420004c2fc1d082c85b90d8a82413b9b34f9c9c5f93f79e6d1eb954b5fdfe41b26fc9a4c44f32844eb40be9b4728a59ec966816a5394d3a0c1f06334b6debecb36f0aea381c13081be3081bb060a2b0601040183a25a01010481ac3081a9045f0803125b3059301306072a8648ce3d020106082a8648ce3d03010703420004d287ad3dc5c97884b7ab987b660efc2aa8cde7f9814e0fb3a8a005bfd8cd4a6cd2fd961d3e2013256b5b59e1ca6c9e7e48febfb1ed90cd092ef24aa0ae2d0dc404463044022021e1ccaf2f3c77fde5ada1242b830e7a5c1ab25956ac5edbca4904ec47a09479022051884dbdda561b545abf3fe391341898a4b4ceccccb83507b445ed36a6b2eedc300a06082a8648ce3d040302034800304502200f0fd126fb521ef8543655ccd3c32b1df34be8eb61ba4d30a04eebdb2870f2b0022100e97a637a3e702f360b45eb7567647c6a46f9d2a53291332a89898f3d84afc24e
Certificate Details:
Issuer: SERIALNUMBER=1913146994707416081
Subject: SERIALNUMBER=1913146994707416081
Serial Number: 1176206223036970174
Not Before: 2025-03-20 10:30:30 +0000 UTC
Not After: 2125-02-24 11:30:30 +0000 UTC

====== Ed25519 Peer:
Peer ID: 12D3KooWKz2nHY8tmcX7ziGsF3gBoUZVvCXcmkvn86DaBsGktZfc
Cert hex:
308201b030820156a00302010202081ef0074922d196fd300a06082a8648ce3d040302301e311c301a06035504051313343337323333323535383639393632313939323020170d3235303332303130333033305a180f32313235303232343131333033305a301e311c301a06035504051313343337323333323535383639393632313939323059301306072a8648ce3d020106082a8648ce3d03010703420004799542bfc7bfb7506ecd6d78857796b30e4127c44716fc2caa40922cc578ec9367e5b748c748a3ae576786b9fddeca36f40f2cc883b101e937511bff41ab5232a37c307a3078060a2b0601040183a25a0101046a3068042408011220970ec193ab5f6c556009767d5cdc0477d257807b41468a6f2007b40f03034fc70440db02949ac1e19fa61632baafa30d565eca7c12e84f0fc4341ade332b5ccbac60640fdc59213399d913e6c3c0f1111f92f66f04ee20cfe8f16cecfb7b5ee59205300a06082a8648ce3d040302034800304502203d33964353d80f393415c993a6462d47c7dacc38147ee445953019786ea7b66d022100a693ade35c4edb786bdb0bd09f1cb0c9a5b0bc6b61a97b639b4e3334371e10aa
Certificate Details:
Issuer: SERIALNUMBER=4372332558699621992
Subject: SERIALNUMBER=4372332558699621992
Serial Number: 2229289826246563581
Not Before: 2025-03-20 10:30:30 +0000 UTC
Not After: 2125-02-24 11:30:30 +0000 UTC

====== Secp256k1 Peer:
Peer ID: 16Uiu2HAm9pWJoENCPfqs3NxD58ujsoi8PNAVpDDJxfbuVHSWj1VZ
Cert hex:
308201b83082015fa003020102020831c14b384686f89a300a06082a8648ce3d040302301e311c301a06035504051313313435373936393932373437313131393132373020170d3235303332303130333033305a180f32313235303232343131333033305a301e311c301a06035504051313313435373936393932373437313131393132373059301306072a8648ce3d020106082a8648ce3d03010703420004e5da66e6dc811fef90f2b7a77ec92f8f7a96942899dc31ce649058cff9f9504cbe2c70212b616daef3fb52afa7d75b1c7880f48fdf0565cb7809ffb656b3b540a38184308181307f060a2b0601040183a25a01010471306f04250802122102d5dd09fddbcc150de9cb92e1777d7712ba0e20f526c7a842cc5f134a966cda780446304402202ece49e25a4b743f6965c70fd7c6efcf9101909a12fe81f2df98a5fcc203e49b02206e16a72fa8d1375d6117db99a960c324fe02f54d0853ecc19dda23a4f40949f0300a06082a8648ce3d0403020347003044022022587f895d257d5cf66da1d1c3627910b858443cb887f405e1948dc3e55d80b902200e2f07b93a2e4a487bb4bc721e9431ae723f921d91f84a875758d787c4302fa8
Certificate Details:
Issuer: SERIALNUMBER=1457969927471119127
Subject: SERIALNUMBER=1457969927471119127
Serial Number: 3585229483437127834
Not Before: 2025-03-20 10:30:30 +0000 UTC
Not After: 2125-02-24 11:30:30 +0000 UTC

====== RSA Peer:
Peer ID: QmYdE1tqDdojK4Q5XaXS34ghpDiav9DRpD16zd41y3DTWz
Cert hex:
308203843082032ba00302010202082b49903cfb5a68b0300a06082a8648ce3d040302301e311c301a06035504051313313639333433353539333630383635363737383020170d3235303332303130333033305a180f32313235303232343131333033305a301e311c301a06035504051313313639333433353539333630383635363737383059301306072a8648ce3d020106082a8648ce3d03010703420004acd28cfbbf5237aaa6f72ce3ab6b6ab790fe0788726bb3c39f9256341f786b73f171f385256e40fb60446cd56d832c655bf5e8ff00072edf349970ee9f34e617a382024f3082024b30820247060a2b0601040183a25a010104820237308202330482012b080012a60230820122300d06092a864886f70d01010105000382010f003082010a0282010100b36d3e34b063a8995698b0b60306288512cb54b173a6bb63c29507e2c7dc26f4af8662ca699899e0972911217b80b5f557210e34f83d622242b099e1311f2446c28a2bfea477d65eed6e1f903f276e78f24cf4375955f1bba6d1bdad81d6857cbb52c20060047af919e4b0f58d60e80cb548d3957e353afc3b4bc5164c3d96acb0d709f411820e065fa9194d4fe3641ee5c2a4c565c8deec3e27f121e01c74c0ee6fb711f6dbdd1256d5f092dd8b23b1ea508c3867a31d2e0cae6bfb426167193d19026e2c52b0c903d1bd5c553721920a0bd5fa6f145ab4157822a28c24704fe51d03f61bf4baa34b0d063b0df25703eee3fb2c8399271b1a6e58dbd4ea3c7102030100010482010082a2a37337b7e3f9fe84029fc420d0874305efb84299d471b4356f114c3bc2df7d4f4cd19b046da89afc7506956d0a93c58336bcbf05aaafe69f38356765824e4e701797059745da88644bf1f3f3a6d04c23326ac104115b5f49144acb5b6f6ce8be3fea7d9d1cd94c7a03f751d8aaf9ca0c5cd7355174debcc52e7b8c06b515adee53346bf8e7e91b641fa12d2ec44000a6c531300a25d6aed13cd66057bf6aebc62d30da92ec269c31dbd678990e2ae80de45a1f98788213049afcee3dad47e8b55fd69e63dc910794e421f51bbfa6b5e2e400dbcabc75766619bcdadeba84ecaf88a82fa1781bf159ceec08f8fba0f222aae99759c1212ff64ea810297240300a06082a8648ce3d0403020347003044021f7ca991bb69c6bf55e702cfedcc765d9991b3b524cdf13e99ce2f7c3ec12ecd022100a0688fb3b08d12a1e08c8bb0808eebfce967d691d963e49a9ce33b22b14fc249
Certificate Details:
Issuer: SERIALNUMBER=1693435593608656778
Subject: SERIALNUMBER=1693435593608656778
Serial Number: 3119182808520222896
Not Before: 2025-03-20 10:30:30 +0000 UTC
Not After: 2125-02-24 11:30:30 +0000 UTC

for invalid certificate test case, i have generate certificate using the same method, but slightly modified code which generates different key used to sign the message (Cert Peer ID), from key used for certificate (Peer ID).

====== Invalid certificate 
Peer ID: QmbwMBgFtbyRgLNmwXUSvksUh18wUQpTfrv1aFobXwrmrT
Cert Peer ID: QmdGv949fqffPPuKmhEKu7cHPV9aoSdNLgLHLomkcS1Xq9
Cert hex:
308201f83082019da00302010202081d051a136acdc4ea300a06082a8648ce3d040302301e311c301a06035504051313333037373732313536373332393634323238363020170d3235303332303130333830395a180f32313235303232343131333830395a301e311c301a06035504051313333037373732313536373332393634323238363059301306072a8648ce3d020106082a8648ce3d030107034200043168c3c9c49ec956c48446b64cc9c2c3d19eb7292ec8410ab9db14bef4946e5d14372ff5ae437b66b2fc724180bafeb8424a7bd4e119a02fcbbbabe039d9e6d7a381c23081bf3081bc060a2b0601040183a25a01010481ad3081aa045f0803125b3059301306072a8648ce3d020106082a8648ce3d03010703420004570acac25ebaaf7cc97c83858bff4c1bec26c9fdeb001b443c08cf26aee887099b36b73fa1aab6b3f729d8e9d8a7b789b5addcb79064769722a0da54cb4ceee804473045022100c253946d4c212698afb92095fdf281611f3fe7088f6cc1ccc71950509558459202206213b2c8fd07d53dc4554c54403116cb9d780d2fdd5b05c4447f1f187dbd26b6300a06082a8648ce3d0403020349003046022100c942bba92a2f3a1f639ae20c1c20e3bbea0f69d45c0ca67411a67c5ec71745f4022100896af401d8d137db9d075cb949b26c5808543540f3cf823352f53e920b5c7d55
Certificate Details:
Issuer: SERIALNUMBER=3077721567329642286
Subject: SERIALNUMBER=3077721567329642286
Serial Number: 2091106272682034410
Not Before: 2025-03-20 10:38:09 +0000 UTC
Not After: 2125-02-24 11:38:09 +0000 UTC

@vladopajic
Copy link
Contributor Author

also here is the comment in go-libp2p implementation, which also makes point that issuer field must be set.

@MarcoPolo, please let me know your feedback.

@MarcoPolo
Copy link
Contributor

Is it possible to make the generating code deterministic (even if you have to hard code the private keys)? If so it would be useful to include here or in the appendix so we have it for reference.

@vladopajic
Copy link
Contributor Author

@MarcoPolo not really... well, technically it would be possible to have some code that deterministically generate certificates, but not with the way i have generated (just called go-libp2p utility). to generate these certificate 100% deterministically we would have to get code from this go utility to this generating program, and hardcore everything (all keys, serial numbers, dates...).

i can paste this generating program here, for future reference, but why would it really need to be deterministic?

@vladopajic
Copy link
Contributor Author

here is the program that will deterministically generate certificates https://github.com/vladopajic/libp2p-cert-generator.

output is this:

====== Ed25519 Peer:
Private key bytes: e8c9bf5ba295dbe3a8b0bf24a08910e3a01618ee74bd25f671a6b492b51137bfa77f1d92fedb59dddaea5a1c4abd1ac2fbde7d7b879ed364501809923d7c11b9
Peer ID: 12D3KooWM6CgA9iBFZmcYAHA6A2qvbAxqfkmrYiRQuz3XEsk4Ksv
Cert bytes:
308201ae30820156a0030201020204499602d2300a06082a8648ce3d040302302031123010060355040a13096c69627032702e696f310a300806035504051301313020170d3735303130313133303030305a180f34303936303130313133303030305a302031123010060355040a13096c69627032702e696f310a300806035504051301313059301306072a8648ce3d020106082a8648ce3d030107034200040c901d423c831ca85e27c73c263ba132721bb9d7a84c4f0380b2a6756fd601331c8870234dec878504c174144fa4b14b66a651691606d8173e55bd37e381569ea37c307a3078060a2b0601040183a25a0101046a3068042408011220a77f1d92fedb59dddaea5a1c4abd1ac2fbde7d7b879ed364501809923d7c11b90440d90d2769db992d5e6195dbb08e706b6651e024fda6cfb8846694a435519941cac215a8207792e42849cccc6cd8136c6e4bde92a58c5e08cfd4206eb5fe0bf909300a06082a8648ce3d0403020346003043021f50f6b6c52711a881778718238f650c9fb48943ae6ee6d28427dc6071ae55e702203625f116a7a454db9c56986c82a25682f7248ea1cb764d322ea983ed36a31b77
Certificate Details:
Issuer: SERIALNUMBER=1,O=libp2p.io
Subject: SERIALNUMBER=1,O=libp2p.io
Serial Number: 1234567890
Not Before: 1975-01-01 13:00:00 +0000 UTC
Not After: 4096-01-01 13:00:00 +0000 UTC
Public Key Algorithm: ECDSA
Signature Algorithm: ECDSA-SHA256


====== ECDSA Peer:
Private key bytes: 307702010104206849bb3add13509b076d7e6a2b1554c8c219aa03e9b9f1e94f3cca8284197199a00a06082a8648ce3d030107a14403420004bf30511f909414ebdd3242178fd290f093a551cf75c973155de0bb5a96fedf6cb5d52da7563e794b512f66e60c7f55ba8a3acf3dd72a801980d205e8a1ad29f2
Peer ID: QmfXbAwNjJLXfesgztEHe8HwgVDCMMpZ9Eax1HYq6hn9uE
Cert bytes:
308201f63082019da0030201020204499602d2300a06082a8648ce3d040302302031123010060355040a13096c69627032702e696f310a300806035504051301313020170d3735303130313133303030305a180f34303936303130313133303030305a302031123010060355040a13096c69627032702e696f310a300806035504051301313059301306072a8648ce3d020106082a8648ce3d030107034200040c901d423c831ca85e27c73c263ba132721bb9d7a84c4f0380b2a6756fd601331c8870234dec878504c174144fa4b14b66a651691606d8173e55bd37e381569ea381c23081bf3081bc060a2b0601040183a25a01010481ad3081aa045f0803125b3059301306072a8648ce3d020106082a8648ce3d03010703420004bf30511f909414ebdd3242178fd290f093a551cf75c973155de0bb5a96fedf6cb5d52da7563e794b512f66e60c7f55ba8a3acf3dd72a801980d205e8a1ad29f2044730450220064ea8124774caf8f50e57f436aa62350ce652418c019df5d98a3ac666c9386a022100aa59d704a931b5f72fb9222cb6cc51f954d04a4e2e5450f8805fe8918f71eaae300a06082a8648ce3d04030203470030440220799395b0b6c1e940a7e4484705f610ab51ed376f19ff9d7c16757cfbf61b8d4302206205c03fbb0f95205c779be86581d3e31c01871ad5d1f3435bcf375cb0e5088a
Certificate Details:
Issuer: SERIALNUMBER=1,O=libp2p.io
Subject: SERIALNUMBER=1,O=libp2p.io
Serial Number: 1234567890
Not Before: 1975-01-01 13:00:00 +0000 UTC
Not After: 4096-01-01 13:00:00 +0000 UTC
Public Key Algorithm: ECDSA
Signature Algorithm: ECDSA-SHA256


====== Secp256k1 Peer:
Private key bytes: 8d7e1f8aa7af251fbd2039e6856d405dd774dbecceef8c580ddd6d718e56d184
Peer ID: 16Uiu2HAkutTMoTzDw1tCvSRtu6YoixJwS46S1ZFxW8hSx9fWHiPs
Cert bytes:
308201ba3082015fa0030201020204499602d2300a06082a8648ce3d040302302031123010060355040a13096c69627032702e696f310a300806035504051301313020170d3735303130313133303030305a180f34303936303130313133303030305a302031123010060355040a13096c69627032702e696f310a300806035504051301313059301306072a8648ce3d020106082a8648ce3d030107034200040c901d423c831ca85e27c73c263ba132721bb9d7a84c4f0380b2a6756fd601331c8870234dec878504c174144fa4b14b66a651691606d8173e55bd37e381569ea38184308181307f060a2b0601040183a25a01010471306f0425080212210206dc6968726765b820f050263ececf7f71e4955892776c0970542efd689d2382044630440220145e15a991961f0d08cd15425bb95ec93f6ffa03c5a385eedc34ecf464c7a8ab022026b3109b8a3f40ef833169777eb2aa337cfb6282f188de0666d1bcec2a4690dd300a06082a8648ce3d0403020349003046022100e1a217eeef9ec9204b3f774a08b70849646b6a1e6b8b27f93dc00ed58545d9fe022100b00dafa549d0f03547878338c7b15e7502888f6d45db387e5ae6b5d46899cef0
Certificate Details:
Issuer: SERIALNUMBER=1,O=libp2p.io
Subject: SERIALNUMBER=1,O=libp2p.io
Serial Number: 1234567890
Not Before: 1975-01-01 13:00:00 +0000 UTC
Not After: 4096-01-01 13:00:00 +0000 UTC
Public Key Algorithm: ECDSA
Signature Algorithm: ECDSA-SHA256


====== RSA Peer:
Private key bytes: 308204a30201000282010100c6423f0fa8757d15b9e9332126339f32395b3f5d16e639b9d030e0507e60e68c973607dad6a2994a5b5f80456de271f21faee9051807e846ade5b396c661eef046e1f8f2279182df845f8962040cf08f6cfadcfde9c4592a0d11b92edab459e9099535db595834c8db762136a164f159bb01a5545a24e0f453df420e6633a9cbc123454b68c11966bc9851993608875e804cfe65604ac60f357b226ba57de0c191039935f7c0c85f1d3de7c2aeb7e6a1520f7201542b949784feb85d53d99f034a55218e6c4fae870cddf7dbb43583cd9eb1bc9e5111c0e7cf62aafef1188711ba205b87c8c95a4ccf154881a49e8b155c795fc1c7621b3b95b01ce4af48a6a70203010001028201007b5a6c72099650255c6ec3e934239a415d7e708632e13bb968d7803994e8258a03eb12280eb34c3cff6d041a2eac5dc90ffd7bee376d740fc5d2cd525a4c44a62af41e384c7634bf6d5523dd6037ccd4f031859e55fc5c9dd553d9ac55573139d5448925d909108e883d8f9cb5fe604c3c16620f81a6c070445efc7289144be7e8646a5bf6702e44edb4967e0c3cfbdb66a672501423aef2c53443d7fcaaf2826608d243becb71b546684042d6641174c9914dfc0632d20bae277d9f1ee33ea320e256b35a00bb09e0869404dbb1cdef31055e42eddad1f3d6e71a44e65bf54d2ce13fbd2c6b898707623ac756c7b22f0dbf89af3c9ab0b82b2f5b0c48ce9c8102818100fad9645884995b4ffac31dfc68322c26b8bd651bfef539bc0b124f088f6ed587a5a3365877f22950f333a54dfee1144d9b6cb15d2856c8c6d87355cec1cf4e441f040990c819c329d6186b16759b9c394c08f2d2c11eb161e80f214e426fcc5c2c9d680c9069dc4744722b2666cfda1391363b78f8e7de37f973467a50718ef902818100ca5468a7f318b20d8a79837467cf5fd613306a48e33e868226992fb9ac0398fac84c7eb637562d570a76b47fb1dae40d209fb109b37f7616e35ef63a9d7a153d56c72064997ca7d831b22f3a92c9a8b0ceb0202e6e431f19f6a06d0953983b7b06b741d7dc4138176a88fbd89845113269aec75febcc129b10f708f848ac2a9f02818026a0cb5f062c476f6d82166003fb95e8f091d9bc11ead95527af4e1457620de7b18e0c945b0423709fc2d835c6860a8658e4c7fb3c7700bbfe20e499ce268a3adb3bd7ed3fa317f69d4d6d502c14265e7c62f46197f38e0531a302d1f65118fb28b3a48e2abee278e7055db7b02559c3a19ce453a0a0b40b929239cc240f18a102818100a2616e00e46bfc723ba15c2bef28925ca7d7e2650ee3de65d3fe7b3c035e7bc7413b8b324865044c67dc6eee50da40ce7c514d6f60bcba149274631f15c5a6082d7df0746c6e8bf249a81c9960b731887cc9037ae009448bbcd071d1db6240d272c85eb294554f64139f4ea83d44a9119199b0ef3db9f170bc03d712149900370281806d57a9aad3e6c2055e923f7b942181a9339dc7378d7dc846046437fd349f32c4a936889ea5ae9c9716a8fe31c830042302d1bc4c9b2d81eac0234269ec27d87d8962a92a40aa9db767ca9f74d78a7b434eae98f01bad0b2a1e9b5db144e78221852f3159e5e98828fc175d5e1b7e06a19e3f751431e9849c950da565c11f487d
Peer ID: QmXsmtNnfvVdbDaPK415Zw3sjcS49aNfE33PtrQPtoyUfa
Cert bytes:
308203863082032ba0030201020204499602d2300a06082a8648ce3d040302302031123010060355040a13096c69627032702e696f310a300806035504051301313020170d3735303130313133303030305a180f34303936303130313133303030305a302031123010060355040a13096c69627032702e696f310a300806035504051301313059301306072a8648ce3d020106082a8648ce3d030107034200040c901d423c831ca85e27c73c263ba132721bb9d7a84c4f0380b2a6756fd601331c8870234dec878504c174144fa4b14b66a651691606d8173e55bd37e381569ea382024f3082024b30820247060a2b0601040183a25a010104820237308202330482012b080012a60230820122300d06092a864886f70d01010105000382010f003082010a0282010100c6423f0fa8757d15b9e9332126339f32395b3f5d16e639b9d030e0507e60e68c973607dad6a2994a5b5f80456de271f21faee9051807e846ade5b396c661eef046e1f8f2279182df845f8962040cf08f6cfadcfde9c4592a0d11b92edab459e9099535db595834c8db762136a164f159bb01a5545a24e0f453df420e6633a9cbc123454b68c11966bc9851993608875e804cfe65604ac60f357b226ba57de0c191039935f7c0c85f1d3de7c2aeb7e6a1520f7201542b949784feb85d53d99f034a55218e6c4fae870cddf7dbb43583cd9eb1bc9e5111c0e7cf62aafef1188711ba205b87c8c95a4ccf154881a49e8b155c795fc1c7621b3b95b01ce4af48a6a7020301000104820100ab0ed7f294e3ec740cb5842ec3d0fc5a0458e00b60bb6c9ee0da8626d0cc1a50cbeb4cc1d61e9a487b327627600b7474e29f5d6c2f66c24966b3524c87e9edc42a3461fb183ce92127b160cf1be599f04a68a22cb463c266181b87e265d418ebff1bcf255bd5e5c1db783ff5909db37c183af5532563c847f104b540855727af53c0412d181f0893e150d5a28e0e9562ff301ff1278264a724152abf0e79537d52cddc205a0f5205490f18218b28ec8051b887033572ace045c24bfe3c0c72d18171148fac43f8b3a494a4ba90d27e554f64c17dc8513597078409e813791d79ee225bf6a2d8dc0893304f74b949230dad4ee4e1cfa62fa1c9ff0439bcda79c3300a06082a8648ce3d0403020349003046022100b3f1961bb314db110f9aae02e1ca0db9cbfda089635a6b99f257661db41a913d022100c04cad46601322e10cf092360a5a290148dfca40fdf7050c977863c57b407144
Certificate Details:
Issuer: SERIALNUMBER=1,O=libp2p.io
Subject: SERIALNUMBER=1,O=libp2p.io
Serial Number: 1234567890
Not Before: 1975-01-01 13:00:00 +0000 UTC
Not After: 4096-01-01 13:00:00 +0000 UTC
Public Key Algorithm: ECDSA
Signature Algorithm: ECDSA-SHA256


====== Invalid certifiacte:
Private key bytes: 307702010104206849bb3add13509b076d7e6a2b1554c8c219aa03e9b9f1e94f3cca8284197199a00a06082a8648ce3d030107a14403420004bf30511f909414ebdd3242178fd290f093a551cf75c973155de0bb5a96fedf6cb5d52da7563e794b512f66e60c7f55ba8a3acf3dd72a801980d205e8a1ad29f2
Peer ID: QmfXbAwNjJLXfesgztEHe8HwgVDCMMpZ9Eax1HYq6hn9uE
Cert bytes:
308201f73082019da0030201020204499602d2300a06082a8648ce3d040302302031123010060355040a13096c69627032702e696f310a300806035504051301313020170d3735303130313133303030305a180f34303936303130313133303030305a302031123010060355040a13096c69627032702e696f310a300806035504051301313059301306072a8648ce3d020106082a8648ce3d030107034200040c901d423c831ca85e27c73c263ba132721bb9d7a84c4f0380b2a6756fd601331c8870234dec878504c174144fa4b14b66a651691606d8173e55bd37e381569ea381c23081bf3081bc060a2b0601040183a25a01010481ad3081aa045f0803125b3059301306072a8648ce3d020106082a8648ce3d03010703420004bf30511f909414ebdd3242178fd290f093a551cf75c973155de0bb5a96fedf6cb5d52da7563e794b512f66e60c7f55ba8a3acf3dd72a801980d205e8a1ad29f204473045022100bb6e03577b7cc7a3cd1558df0da2b117dfdcc0399bc2504ebe7de6f65cade72802206de96e2a5be9b6202adba24ee0362e490641ac45c240db71fe955f2c5cf8df6e300a06082a8648ce3d0403020348003045022100e847f267f43717358f850355bdcabbefb2cfbf8a3c043b203a14788a092fe8db022027c1d04a2d41fd6b57a7e8b3989e470325de4406e52e084e34a3fd56eef0d0df
Certificate Details:
Issuer: SERIALNUMBER=1,O=libp2p.io
Subject: SERIALNUMBER=1,O=libp2p.io
Serial Number: 1234567890
Not Before: 1975-01-01 13:00:00 +0000 UTC
Not After: 4096-01-01 13:00:00 +0000 UTC
Public Key Algorithm: ECDSA
Signature Algorithm: ECDSA-SHA256

@vladopajic
Copy link
Contributor Author

vladopajic commented Mar 25, 2025

@MarcoPolo please let me know your feedback. i'll update information in spec once it is confirmed that certificates are correct. PRs in go and nim implementations are updated and passing tests.

@vladopajic
Copy link
Contributor Author

@MarcoPolo hey, any feedback on this?

@MarcoPolo
Copy link
Contributor

Will take a look at this today, apologies for the delay

@MarcoPolo
Copy link
Contributor

Looks good. Thank you for tidying this up. Ping me when you update the text in the tls spec

@MarcoPolo MarcoPolo merged commit fd717da into libp2p:master Mar 31, 2025
@github-project-automation github-project-automation bot moved this from Triage to Done in libp2p Specs Mar 31, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants