-
Notifications
You must be signed in to change notification settings - Fork 1.2k
chore(certificate): update test vectors #3242
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
MarcoPolo
merged 7 commits into
libp2p:master
from
vladopajic:tls-certificate-test-vector
Apr 7, 2025
Merged
chore(certificate): update test vectors #3242
MarcoPolo
merged 7 commits into
libp2p:master
from
vladopajic:tls-certificate-test-vector
Apr 7, 2025
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dear maintainers, it would be nice to approve workflows to show that tests are passing. thanks! |
MarcoPolo
approved these changes
Mar 31, 2025
Once you get this out of draft we can merge |
@MarcoPolo it's out of draft now. |
MarcoPolo
approved these changes
Apr 2, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for pushing this along 💜
will merge after CI passes |
@MarcoPolo you're welcome sir |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this PR updates test vectors for tls certificate, following pending PR in specs libp2p/specs#665.
this PR also serves as demo that new test vector values are passing tests.
this PR is in draft until specs are reviewed. i'll make sure to close it, or mark for review after it gets approved.