Skip to content

Conversation

vladopajic
Copy link
Contributor

@vladopajic vladopajic commented Mar 19, 2025

this PR updates test vectors for tls certificate, following pending PR in specs libp2p/specs#665.
this PR also serves as demo that new test vector values are passing tests.

this PR is in draft until specs are reviewed. i'll make sure to close it, or mark for review after it gets approved.

@vladopajic vladopajic marked this pull request as draft March 19, 2025 15:01
@vladopajic vladopajic marked this pull request as ready for review March 19, 2025 15:17
@vladopajic vladopajic marked this pull request as draft March 19, 2025 15:17
@vladopajic
Copy link
Contributor Author

dear maintainers, it would be nice to approve workflows to show that tests are passing. thanks!

@sukunrt sukunrt self-requested a review March 19, 2025 17:09
@MarcoPolo
Copy link
Collaborator

Once you get this out of draft we can merge

@vladopajic vladopajic marked this pull request as ready for review April 1, 2025 07:47
@vladopajic
Copy link
Contributor Author

@MarcoPolo it's out of draft now.

Copy link
Collaborator

@MarcoPolo MarcoPolo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for pushing this along 💜

@MarcoPolo
Copy link
Collaborator

will merge after CI passes

@vladopajic
Copy link
Contributor Author

@MarcoPolo you're welcome sir

@MarcoPolo MarcoPolo merged commit 2aa0bca into libp2p:master Apr 7, 2025
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants