You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is a work in progress PR that allow 64k vertices mesh instead of 32k.
There might be some other impacts like with Bullet, i have to test a bit more. Note that i tested it against desktop and GWT.
I didn't wanted to spread this change to 2D domain (sprite batch and such) for now.
I wanted to have a feedback about this change before going further.
I now that fbx-conv doesn't allow 64k vertices yet but other loaders does (eg. OBJ loader). I needed this change for my GLTF library so i monkey patched Mesh class and it works well so far, so i wanted to share this improvement.
Note that i also fixed an issue in ModelCache using indices count instead of vertices count. I'm not fully satisfied with the fix: we don't know how many vertices are needed without counting indices in mesh part to add. I could isolate this fix in another PR if you think it's prefereable.
I quickly discussed about it with @xoppa recently, i wasn't sure if there was other reasons than java unsigned short for this limitation.
I've run BigMeshTest on an iPad Mini 5 and the Simulator (both iOS 13.4) and I get a totally black screen with the following logs https://pastebin.com/tCPk47b3. Just to confirm is not a problem of the tests on iOS instead of your changes, is there an equivalent test I can run that should work without your PR?
@noblemaster done! feel free to squash and reword if necessary. I checked, there are no breaking changes except that now indices can be negative short and need to be properly converted to int in some cases.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a work in progress PR that allow 64k vertices mesh instead of 32k.
There might be some other impacts like with Bullet, i have to test a bit more. Note that i tested it against desktop and GWT.
I didn't wanted to spread this change to 2D domain (sprite batch and such) for now.
I wanted to have a feedback about this change before going further.
I now that fbx-conv doesn't allow 64k vertices yet but other loaders does (eg. OBJ loader). I needed this change for my GLTF library so i monkey patched Mesh class and it works well so far, so i wanted to share this improvement.
Note that i also fixed an issue in ModelCache using indices count instead of vertices count. I'm not fully satisfied with the fix: we don't know how many vertices are needed without counting indices in mesh part to add. I could isolate this fix in another PR if you think it's prefereable.
I quickly discussed about it with @xoppa recently, i wasn't sure if there was other reasons than java unsigned short for this limitation.
Tell me what do you think about it.