Skip to content

staged signs (take 2) #535

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 15, 2022
Merged

staged signs (take 2) #535

merged 1 commit into from
Dec 15, 2022

Conversation

lewis6991
Copy link
Owner

@lewis6991 lewis6991 commented Apr 18, 2022

Example: second hunk in the screenshot is staged:

Screenshot 2022-04-18 at 21 54 53

@lewis6991 lewis6991 force-pushed the sec2 branch 15 times, most recently from 52430ba to 56fb4e1 Compare April 22, 2022 14:26
This was linked to issues Apr 28, 2022
@lewis6991 lewis6991 force-pushed the sec2 branch 2 times, most recently from 3cf0aad to eed0072 Compare May 6, 2022 22:01
sitedyno added a commit to sitedyno/nvim-config that referenced this pull request Jun 24, 2022
I dislike the way Neogit has it's own filetype for commits. It's hard
(for me) to use with other plugins that check for the `gitcommit`
filetype and have them all work together properly.

Keeping Neogit for now only because it allows for unstaging hunks.
Gitsigns will eventually show staged hunks so they can be unstaged:
lewis6991/gitsigns.nvim#535
@lewis6991 lewis6991 force-pushed the sec2 branch 3 times, most recently from 201456a to 51b8ed3 Compare December 15, 2022 12:23
@lewis6991 lewis6991 changed the title WIP: staged signs (take 2) staged signs (take 2) Dec 15, 2022
@lewis6991
Copy link
Owner Author

Behaviour of this is a bit wonky in places, but going to submit this as a hidden feature that can be enabled with config._signs_staged_enable = true.

@lewis6991 lewis6991 merged commit d572faa into main Dec 15, 2022
@lewis6991 lewis6991 deleted the sec2 branch December 15, 2022 12:53
@rockyzhang24
Copy link
Contributor

Great enhancement 👍
Do you consider to make preview_hunk work in the staged hunk as well?

@lewis6991
Copy link
Owner Author

Haven't considered it but it sounds like a good idea!

@lewis6991
Copy link
Owner Author

I've added support for most actions that made sense. Let me know if any are missing.

@clason
Copy link
Collaborator

clason commented Dec 23, 2022

Docs are missing ;)

@lewis6991
Copy link
Owner Author

Still a hidden feature. Docs will become visible when the _ prefix is removed from the config entries.

@clason
Copy link
Collaborator

clason commented Dec 23, 2022

Sure; I meant here for people interested in testing it out.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unstage hunk Add signs for staged hunks
3 participants