Handle broken site_config #774
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
justinmk
commented
Mar 8, 2018
| if not ok then | ||
| if type(site_config) ~= "table" then | ||
| io.stderr:write("Result of require('luarocks.core.site_config_"..version_suffix.."') was invalid.\n") | ||
| site_config = {} |
There was a problem hiding this comment.
Maybe it should fail instead of trying to recover here. I'll leave that up to the luarocks maintainers.
justinmk
added a commit
to justinmk/neovim
that referenced
this pull request
Mar 8, 2018
justinmk
added a commit
to justinmk/neovim
that referenced
this pull request
Mar 9, 2018
|
Are you guys running |
|
@hishamhm Yes, until yesterday: neovim/neovim@3029bae Even so, it's worth having some sort of warning about this situation, no? |
justinmk
added a commit
to justinmk/neovim
that referenced
this pull request
Mar 9, 2018
justinmk
added a commit
to justinmk/neovim
that referenced
this pull request
Mar 9, 2018
Is there a race between the luarocks `make bootstrap` dependencies? reverts f73b4911312b35bfe38ed068672a2f8ba8875ba7 ref luarocks/luarocks#774
justinmk
added a commit
to justinmk/neovim
that referenced
this pull request
Mar 11, 2018
justinmk
added a commit
to justinmk/neovim
that referenced
this pull request
Mar 11, 2018
Is there a race between the luarocks `make bootstrap` dependencies? reverts f73b4911312b35bfe38ed068672a2f8ba8875ba7 ref luarocks/luarocks#774
|
The fix should be to have the |
|
IMO nil reference errors should be handled informatively where possible. Closing this in the meantime. |
|
@justinmk FYI, with the release of luarocks 3.0, site_config.lua no longer exists. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On travis CI the Neovim project sometimes sees errors like this:
That "attempt to index local 'site_config' (a boolean value)" error is annoying and requires digging around to find why it might happen.
require()returnstrueif the module doesn't return anything, so that's whysite_configis "a boolean value".Of course, the deeper problem[1] is that the
require()is being weird. But showing a hint is better than nothing.[1] My guess is that
make bootstrapis doing things in parallel, maybe the site_config file is not fully written when therequire()is invoked. Or travis (or the CI cache) is being weird.