Simplify test container usage for kotest 6 #4925
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Kantis
reviewed
Jul 7, 2025
Comment on lines
+10
to
+22
| /** | ||
| * A Kotest [MountableExtension] for [GenericContainer]s that will launch the container | ||
| * upon first install, and close after the test suite has completed. This extension will only | ||
| * launch the container once per project, and will not reset it between specs. | ||
| * | ||
| * Note: This extension requires Kotest 6.0+ | ||
| * | ||
| * @param container the specific test container type | ||
| */ | ||
| class TestContainerProjectExtension( | ||
| private val container: GenericContainer<*>, | ||
| ) : MountableExtension<GenericContainer<*>, Unit>, AfterProjectListener, TestListener { | ||
|
|
There was a problem hiding this comment.
Would this be installed from an AbstractProjectConfig? Or would you just install it in every spec that uses the container anyway?
There was a problem hiding this comment.
You install it in every one, but it's only started once, so your test suite is quick. It's like a "lazy" container basically.
We use this pattern everywhere at Grindr.
Kantis
pushed a commit
to JesusMcCloud/kotest
that referenced
this pull request
Jul 12, 2025
<!-- If this PR updates documentation, please update all relevant versions of the docs, see: https://github.com/kotest/kotest/tree/master/documentation/versioned_docs The documentation at https://github.com/kotest/kotest/tree/master/documentation/docs is the documentation for the next minor or major version _TO BE RELEASED_ -->
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.