conditional publication enabled based on runner, to deal with sharded… #4918
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aSemy
approved these changes
Jul 4, 2025
aSemy
reviewed
Jul 5, 2025
Comment on lines
+34
to
+37
| # Kotest build settings | ||
| # enabled/disable Kotlin targets, for improving local dev & CI/CD performance | ||
| kotest_enableKotlinJs=true | ||
| kotest_enableKotlinNative=false |
There was a problem hiding this comment.
Will this config also disable the native tests on CI?
There was a problem hiding this comment.
Good catch.. we should explicitly enable all targets in CI no matter the checked in config..
Kantis
added a commit
to JesusMcCloud/kotest
that referenced
this pull request
Jul 12, 2025
kotest#4918) Cherry-picked some stuff from @aSemy's work on Ks3's build setup. This enables us to only allow publications to be created on certain targets, so we can run macOS builds and just get Apple targets artifacts, etc. <!-- If this PR updates documentation, please update all relevant versions of the docs, see: https://github.com/kotest/kotest/tree/master/documentation/versioned_docs The documentation at https://github.com/kotest/kotest/tree/master/documentation/docs is the documentation for the next minor or major version _TO BE RELEASED_ -->
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cherry-picked some stuff from @aSemy's work on Ks3's build setup.
This enables us to only allow publications to be created on certain targets, so we can run macOS builds and just get Apple targets artifacts, etc.