Restore instance per leaf and test; simplify spec execution scopes #4916
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Kantis
approved these changes
Jul 6, 2025
...ngine/src/jvmTest/kotlin/com/sksamuel/kotest/engine/extensions/spec/AfterSpecListenerTest.kt
Outdated
Show resolved
Hide resolved
…m/sksamuel/kotest/engine/extensions/spec/AfterSpecListenerTest.kt Co-authored-by: Emil Kantis <emil.kantis@protonmail.com>
Kantis
added a commit
to JesusMcCloud/kotest
that referenced
this pull request
Jul 12, 2025
…otest#4916) To avoid migration issues in the upcoming 6.0, this re-adds the removed isolation modes, albeit with instance per leaf deprecated. I've moved duplicate name handling and fail fast out of the scopes and into interceptors so in a follow up PR we can really simplify the scope stuff. --------- Co-authored-by: Emil Kantis <emil.kantis@protonmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To avoid migration issues in the upcoming 6.0, this re-adds the removed isolation modes, albeit with instance per leaf deprecated. I've moved duplicate name handling and fail fast out of the scopes and into interceptors so in a follow up PR we can really simplify the scope stuff.