Fix Exhaustive.Companion.azstring #4850
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sksamuel
approved these changes
Apr 21, 2025
|
Great thanks! |
habara-k
pushed a commit
to habara-k/kotest
that referenced
this pull request
Apr 23, 2025
According the [documentation](https://kotest.io/docs/proptest/property-test-generators-list.html), "`Exhaustive.azstring(1..2)` ... [returns] `a, b, c, ...., yz, zz`". The `yz` seems to imply that it generates all possible permutations; however, this doesn't seem to be the case. For example for `Exhaustive.azstring(2..2)` should produce `aa, ab, ac, ... , zx, zy, zz` but instead produces `aa, bb, cc, ... , xx, yy, zz`. There is a mismatch between the code and the documentation. My changes updates the code to match the written behavior. If the current behavior is intentional, I can change this pull request to update the documentation instead (and update the test to match the current behavior)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
According the documentation, "
Exhaustive.azstring(1..2)... [returns]a, b, c, ...., yz, zz". Theyzseems to imply that it generates all possible permutations; however, this doesn't seem to be the case. For example forExhaustive.azstring(2..2)should produceaa, ab, ac, ... , zx, zy, zzbut instead producesaa, bb, cc, ... , xx, yy, zz. There is a mismatch between the code and the documentation.My changes updates the code to match the written behavior. If the current behavior is intentional, I can change this pull request to update the documentation instead (and update the test to match the current behavior)