Enable coroutineTestScope on js and wasmJs #4813
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sksamuel
approved these changes
Apr 23, 2025
|
thanks! |
Kantis
pushed a commit
to JesusMcCloud/kotest
that referenced
this pull request
Jul 12, 2025
<!-- If this PR updates documentation, please update all relevant versions of the docs, see: https://github.com/kotest/kotest/tree/master/documentation/versioned_docs The documentation at https://github.com/kotest/kotest/tree/master/documentation/docs is the documentation for the next minor or major version _TO BE RELEASED_ --> This is a very simple change and I am not deeply in the kotest codebase. I used this workaround for some projects internally and it seems to work. If these changes are acceptable I'd be able to add some tests for this too, akin to the already existing tests for the coroutineTestScope on the jvm. As I am not too familiar it would be a great help if you could point me to the right direction for adding tests on js and wasmjs. This might close kotest#4077 Co-authored-by: Sam <sam@sksamuel.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a very simple change and I am not deeply in the kotest codebase. I used this workaround for some projects internally and it seems to work.
If these changes are acceptable I'd be able to add some tests for this too, akin to the already existing tests for the coroutineTestScope on the jvm. As I am not too familiar it would be a great help if you could point me to the right direction for adding tests on js and wasmjs.
This might close #4077