Remove TimeMarkCompat / MonotonicTimeSourceCompat / timeInMillis #4105
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
7154db3 to
6ad1a78
Compare
TimeMarkCompat was only necessary because of a breaking change in Kotlin 1.7 - but that was 2 years ago and Kotest now requires more recent versions, so TimeMarkCompat can now be removed.
timeInMillis is only used for measuring times, so it can be replaced with stdlib `measureTime {}`/`measureTimedValue {}`
6ad1a78 to
13ddc72
Compare
# Conflicts: # kotest-common/api/kotest-common.api
sksamuel
approved these changes
Jun 15, 2024
|
nice update |
… they're pretty-printed using Duration#toString)
aSemy
commented
Jun 15, 2024
| try { | ||
| result = f() | ||
| listener?.invoke(ContinuallyState(result, start, end, times)) | ||
| listener?.invoke(ContinuallyState(result, 0L, duration.inWholeMilliseconds, times)) |
There was a problem hiding this comment.
Just to highlight, there's a potentially breaking change here.
The start and end of a ContinuallyState will no longer reflect the system time, but start will always be 0, and end will always be the configured duration.
I think this change is acceptable because it's a minor change, and this code has been deprecated for ~3 years.
There was a problem hiding this comment.
agreed, all deprecated functions are coming out for 6.0
20 tasks
# Conflicts: # kotest-assertions/kotest-assertions-core/src/jvmTest/kotlin/io/kotest/assertions/nondeterministic/EventuallyTest.kt # kotest-assertions/kotest-assertions-shared/src/jvmTest/kotlin/com/sksamuel/kotest/assertions/until/UntilTest.kt
sksamuel
approved these changes
Jun 17, 2024
aSemy
added a commit
that referenced
this pull request
Jun 17, 2024
Use a test TimeSource in `continually` tests. - The test TimeSource uses a virtual time, so the tests run faster. - The elapsed duration is reproducible, so the tests can assert the specific elapsed time. - Use CoroutineContext to store & retrieve the TimeSource (This helps with testing both `continually(duration)` and `continually(config)` functions, and doesn't require adding an option in `ContinuallyConfiguration`) ### Dependencies * #4105
aSemy
added a commit
that referenced
this pull request
Jun 21, 2024
Use a test TimeSource in `eventually` tests. - The test TimeSource uses a virtual time, so the tests run faster. - The elapsed duration is reproducible, so the tests can assert the specific elapsed time. - Use CoroutineContext to store & retrieve the TimeSource (This helps with testing both `eventually(duration)` and `eventually(config)` functions, and doesn't require adding an option in `EventuallyConfiguration`) Depends on: #4105 Related: #4109 --------- Co-authored-by: OliverO2 <Oliver.O456i@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TimeMarkCompat was only necessary because of a breaking change in Kotlin 1.7 - but that was 2 years ago and Kotest now requires more recent versions, so TimeMarkCompat can now be removed. Slack discussion.
timeInMillis()is only used for measuring times, so it can be replaced with stdlibmeasureTime {}/measureTimedValue {}