Lazily dealing with eq-results #4048
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We can defer the cost of creating failure messages and throwing exceptions until as late as possible. When negating/inverting matchers, we actually want the failure and in those cases the cost of generating messages+exceptions is spent in vain. Fixes #4041
|
IMO same thing should be done in several other places, such as collection matchers: if the expected outcome is failure, they shouldn't waste time describing differences |
github-merge-queue bot
pushed a commit
that referenced
this pull request
Jul 20, 2024
When we throw an AssertionError and the matcher is actually used by an inverted matcher (i.e. we expect a failure), then the stacktrace is irrelevant. Partially fixes #4041 #4048 fixes rest, but this fix can go into next patch and fixes 2/3rds of the performance costs <!-- If this PR updates documentation, please update all relevant versions of the docs, see: https://github.com/kotest/kotest/tree/master/documentation/versioned_docs The documentation at https://github.com/kotest/kotest/tree/master/documentation/docs is the documentation for the next minor or major version _TO BE RELEASED_ --> Co-authored-by: Sam <sam@sksamuel.com>
|
What do we want to do with this ? |
|
this problem persists in multiple places. this PR exposes just the tip of this iceberg. we can start making similar changes elsewhere |
|
Agreed. I will close this PR. I tried rebasing it onto latest master but it's just too many conflicts with things I don't know anything about. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We can defer the cost of creating failure messages and throwing exceptions until as late as possible. When negating/inverting matchers, we actually want the failure and in those cases the cost of generating messages+exceptions is spent in vain.
Also deferring cleaning of stacktraces to top-level saves a lot when dealing with negated matchers.
Fixes #4041
EqResultandEqualityResultshould probably be merged into a single class before merging, since this needs to go in a major release either way