Skip to content

Wait for kube-proxy to start before moving on during runtime upgrade #1509

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 28, 2019
Merged

Wait for kube-proxy to start before moving on during runtime upgrade #1509

merged 1 commit into from
Nov 28, 2019

Conversation

jakolehm
Copy link
Contributor

Waiting for node to be ready is not enough, upgrade might be so fast that node never goes to non-ready state. This PR fixes this situation by waiting for kube-proxy pod before checking node ready status.

@jakolehm jakolehm added the bug Something isn't working label Nov 28, 2019
@jakolehm jakolehm added this to the 2.5.0 milestone Nov 28, 2019
@jakolehm jakolehm requested review from kke and jnummelin November 28, 2019 08:05
@jakolehm jakolehm merged commit 56fa601 into master Nov 28, 2019
@jakolehm jakolehm deleted the fix/wait-for-kube-proxy-running branch November 28, 2019 08:17
jakolehm added a commit that referenced this pull request Nov 28, 2019
@jakolehm
Wait for kube-proxy to start before moving on during runtime upgrade (#…
aa052a6 
…1509)
@jakolehm jakolehm mentioned this pull request Nov 28, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kke kke Awaiting requested review from kke

1 more reviewer

@jnummelin jnummelin jnummelin approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
2.5.0
Development

Successfully merging this pull request may close these issues.
2 participants
@jakolehm @jnummelin