Fix #444 + Kitsu detail change + episode/chapter name marquee effect #445
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Instead of "01 Jan 1970" show "Start date" and "Finish Date" on kitsu. Just like MyAnimeList
- Tracker Kitsu now displays "ì" correctly - Removed a lot of code duplication in Kitsu.
title text scroll (like a marquee effect) when the chapter/episode name is too long.
``` [ERROR:flutter/runtime/dart_vm_initializer.cc(40)] Unhandled Exception: Bad state: Cannot use "ref" after the widget was disposed. #0 ConsumerStatefulElement._assertNotDisposed (package:flutter_riverpod/src/consumer.dart:550:7) consumer.dart:550 #1 ConsumerStatefulElement.read (package:flutter_riverpod/src/consumer.dart:619:5) consumer.dart:619 #2 _MainScreenState.initState.<anonymous closure>.<anonymous closure> (package:mangayomi/modules/main_view/main_screen.dart:70:13) main_screen.dart:70 #3 _Timer._runTimers (dart:isolate-patch/timer_impl.dart:410:19) timer_impl.dart:410 #4 _Timer._handleMessage (dart:isolate-patch/timer_impl.dart:441:5) timer_impl.dart:441 #5 _RawReceivePort._handleMessage (dart:isolate-patch/isolate_patch.dart:194:12) isolate_patch.dart:194 ```
Why was this removed?
```
════════ Exception caught by widgets library ═══════════════════════════════════
The following UnsupportedError was thrown building CircularProgressIndicator(100.0%, dependencies: [InheritedCupertinoTheme, _InheritedTheme, _LocalizationsScope-[GlobalKey#3b6da]], state: _CircularProgressIndicatorState#8c03b(ticker inactive)):
Unsupported operation: Infinity or NaN toInt
The relevant error-causing widget was:
CircularProgressIndicator CircularProgressIndicator (package:mangayomi/modules/manga/reader/widgets/circular_progress_indicator_animate_rotate.dart:56:27)
```
At line 963, when scrolling too fast in manga reader and page didn't load before. ``` ═══════ Exception caught by foundation library ════════════════════════════════ The following StateError was thrown while dispatching notifications for ValueNotifier<Iterable<ItemPosition>>: Bad state: No element ```
removed code duplication
|
Fixed 3 different exceptions:
|
Flutter already knows how to switch the theme automatically. No need to listen to onPlatformBrightnessChanged. This works on cold start. Works when app is running and system theme changes. And works when backup was done on different system theme and restore is being done on different system theme.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before:
After:
https://github.com/user-attachments/assets/32fc90d0-61a1-4d5b-94f6-91bb8e675d8f