Correct directory #5
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
On Windows and Linux the files were created in the ~/Documents folder. Now they will be created in ~/Documents/Mangayomi/databases instead
On Android, iOS and macOS just like how it's done on Windows and Linux. Before the database files were in the top directory.
macOS and iOS already create a separate "Mangayomi" folder. There is no need to nest the downloads and backup folders in another "Mangayomi" folder.
to make the requestPermission() a little shorter. It's just optics. The logic stays the same.
why make it nullable, set a default value and then use a non-null-assertion (!)?
When deleteTmpDirectory() calls getTmpDirectory(), the directory is first being created and then it is being deleted. Redundant operation.
Same as previous commit
potentially fixes kodjodevf#430
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.