fix: check errReadRespBody != nil but return a nil value error err
#2470
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: alingse <alingse@foxmail.com>
|
CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅ |
|
hey @alingse the changes look good, you can surely add the defer body close code in the same PR. |
|
I have read the CLA Document and I hereby sign the CLA |
slayerjain
added a commit
that referenced
this pull request
Dec 16, 2024
add defer httpResp.Body.Close() Signed-off-by: alingse <alingse@foxmail.com>
|
Hey @alingse the linter pipeline is breaking, please fix the same! |
ok, I will fix it later(after work) |
Signed-off-by: alingse <alingse@foxmail.com>
Signed-off-by: alingse <alingse@foxmail.com>
shivamsouravjha
approved these changes
Dec 19, 2024
|
@shivamsouravjha I have update the commit , go fmt the file. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
fix a bug
btw, there should add a
defer httpResp.Body.Close()Related PRs and Issues
I create a linter to detect code that returns a non-relevant nilness error bug. I checked the top 1000 GitHub Go repositories and found this, all result listed in alingse/sundrylint#4
Closes: #[issue number that will be closed through this PR]
Type of change
Please let us know test plan followed
Please describe the tests(if any). Provide instructions how its affecting the coverage.
Checklist: