Verify USB listener callback handle #10872
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bob-beck
pushed a commit
to openbsd/ports
that referenced
this pull request
Jun 9, 2024
On some system, libusb_hotplug_register_callback fails, resulting in long open and closed DB tasks when a YubiKey is involved. I have not found out why libusb_hotplug_register_callback fails which is clear the root cause. However, I had to realize that keepassxc uses "handle" even if it is not valid. keepassxreboot/keepassxc#10872 Tested by gonzalo@, ok kn@
Do not use `handle` if `libusb_hotplug_register_callback` fails
f41dd92 to
cc4fe22
Compare
droidmonkey
approved these changes
Jun 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Do not use
handleiflibusb_hotplug_register_callbackfailsOn OpenBSD USB listener callback fails. When this happens, opening and closing a DB takes a very long time. Maybe through
handleUsbEvents()Testing strategy
Test wit yubikey on OpenBSD -current
Type of change