feat: grpc mTLS certificates are hot reloaded #6756
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jorge Turrado <jorge_turrado@hotmail.es>
Signed-off-by: Jorge Turrado <jorge_turrado@hotmail.es>
Signed-off-by: Jorge Turrado <jorge_turrado@hotmail.es>
Signed-off-by: Jorge Turrado Ferrero <Jorge_turrado@hotmail.es>
|
/run-e2e |
|
I've tested this behavior on my local with 1 hour certs and it works, but I'm not fully sure about how to test this deterministically, as e2e tests can't ensure when the certificate has been updated without checking the logs, and that could be quite flaky. In the other hand, IDK how to unit test this as |
There was a problem hiding this comment.
Pull Request Overview
This PR introduces hot reloading for gRPC mTLS certificates by updating TLS credential loading and integrating a file watcher for certificate changes. Key changes include:
- Adding a context parameter to LoadGrpcTLSCredentials and updating its callers.
- Implementing a file watcher using fsnotify to detect certificate updates.
- Bumping the fsnotify dependency and updating the certificate generation command in BUILD.md.
Reviewed Changes
Copilot reviewed 25 out of 25 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| pkg/metricsservice/utils/tls.go | Updated TLS credentials loading to support certificate hot reloading with fsnotify. |
| pkg/metricsservice/server.go | Updated Start() method to pass context for TLS credentials. |
| pkg/metricsservice/client.go | Updated NewGrpcClient() to pass context for TLS credentials. |
| go.mod | Upgraded fsnotify dependency to v1.9.0. |
| cmd/adapter/main.go | Updated to pass context to NewGrpcClient. |
| CHANGELOG.md | Documented the certificate hot-reloading improvement. |
| BUILD.md | Modified openssl command to include subjectAltName certificate extension. |
wozniakjan
approved these changes
May 9, 2025
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> Signed-off-by: Jorge Turrado Ferrero <Jorge_turrado@hotmail.es>
ab30b85 to
8abbf00
Compare
|
/run-e2e rabbit |
|
It's working: |
wozniakjan
pushed a commit
to wozniakjan/keda
that referenced
this pull request
Jun 17, 2025
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
wozniakjan
pushed a commit
to wozniakjan/keda
that referenced
this pull request
Jun 17, 2025
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> Signed-off-by: Jan Wozniak <wozniak.jan@gmail.com>
wozniakjan
added a commit
that referenced
this pull request
Jun 18, 2025
* feat: grpc mTLS certificates are hot reloaded (#6756) Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> Signed-off-by: Jan Wozniak <wozniak.jan@gmail.com> * fix: temporal scaler was not setting up tls for apikey auth (#6781) * fix: temporal scaler was not setting up tls for apikey auth Signed-off-by: joaopaulosr95 <joaopaulosr95@gmail.com> * Update CHANGELOG.md Co-authored-by: Jan Wozniak <wozniak.jan@gmail.com> Signed-off-by: João Bastos <joaopaulosr95@gmail.com> --------- Signed-off-by: joaopaulosr95 <joaopaulosr95@gmail.com> Signed-off-by: João Bastos <joaopaulosr95@gmail.com> Signed-off-by: Jan Wozniak <wozniak.jan@gmail.com> Co-authored-by: Jan Wozniak <wozniak.jan@gmail.com> Signed-off-by: Jan Wozniak <wozniak.jan@gmail.com> * chore: changelog and issue template v2.17.2 Signed-off-by: Jan Wozniak <wozniak.jan@gmail.com> --------- Signed-off-by: Jan Wozniak <wozniak.jan@gmail.com> Signed-off-by: joaopaulosr95 <joaopaulosr95@gmail.com> Signed-off-by: João Bastos <joaopaulosr95@gmail.com> Co-authored-by: Jorge Turrado Ferrero <Jorge_turrado@hotmail.es> Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> Co-authored-by: João Bastos <joaopaulosr95@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist