Skip to content

fix call log.Error with nil value error #6662

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 30, 2025
Merged

fix call log.Error with nil value error #6662

merged 1 commit into from
Mar 30, 2025

Conversation

alingse
Copy link
Contributor

@alingse alingse commented Mar 30, 2025 •
edited by JorTurFer
Loading

use correct err for log.Error

and the code should be

		log.Error(errscaledjob, "Unable to write to metrics to Prometheus Server", "labels", labels)

but I'm not sure.

Checklist

  • Commits are signed with Developer Certificate of Origin (DCO - learn more)

Fixes #

Relates to #

@alingse
fix call log.Error with nil value error
bfa31d6 
Signed-off-by: alingse <alingse@foxmail.com>
@alingse alingse requested a review from a team as a code owner March 30, 2025 05:33
@alingse alingse mentioned this pull request Mar 30, 2025
Closed
JorTurFer
JorTurFer approved these changes Mar 30, 2025
View reviewed changes
Copy link
Member

@JorTurFer JorTurFer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice catch! Thanks

@JorTurFer
Copy link
Member

JorTurFer commented Mar 30, 2025 •
edited by github-actions bot
Loading

/run-e2e metrics
Update: You can check the progress here

@JorTurFer JorTurFer merged commit c2d4c44 into kedacore:main Mar 30, 2025
22 checks passed
rickbrouwer pushed a commit to rickbrouwer/keda that referenced this pull request Apr 9, 2025
@alingse @rickbrouwer
fix call log.Error with nil value error (kedacore#6662)
f0ccaef 
Signed-off-by: alingse <alingse@foxmail.com>
mittalvaibhav1 pushed a commit to mittalvaibhav1/keda that referenced this pull request Apr 26, 2025
@alingse @mittalvaibhav1
fix call log.Error with nil value error (kedacore#6662)
31db543 
Signed-off-by: alingse <alingse@foxmail.com>
Signed-off-by: mittalvaibhav1 <mittalvaibhavandroid@gmail.com>
mittalvaibhav1 pushed a commit to mittalvaibhav1/keda that referenced this pull request Apr 26, 2025
@alingse @mittalvaibhav1
fix call log.Error with nil value error (kedacore#6662)
c76c8ba 
Signed-off-by: alingse <alingse@foxmail.com>
mittalvaibhav1 pushed a commit to mittalvaibhav1/keda that referenced this pull request Apr 26, 2025
@alingse @mittalvaibhav1
fix call log.Error with nil value error (kedacore#6662)
2beec93 
Signed-off-by: alingse <alingse@foxmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JorTurFer JorTurFer JorTurFer approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@alingse @JorTurFer