External Scaler: support server TLS w/o custom CA #6606
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
242c79d to
b736e42
Compare
gautierdelorme
added a commit
to gautierdelorme/keda-docs
that referenced
this pull request
Mar 5, 2025
Relates to kedacore/keda#6606 Signed-off-by: Gautier Delorme <gautier.delorme@gmail.com>
1 task
Currently TLS is enabled only if the ScaledObject's trigger contains a custom CA certificate or enable client TLS. Else it does not use the default TLS config that includes CAs already loaded by the Operator. This is a problem if we have an external scaler presenting a TLS certificate that should be accepted by the Operator without requiring client TLS. To keep the change backward compatible I've added a new `enableTLS` parameter that can be set to `"true"` to enable TLS w/o client TLS or custom CA. The parameter name is consistent with other scalers (e.g. Metrics API, Redis, Kafka...). Signed-off-by: Gautier Delorme <gautier.delorme@gmail.com>
b736e42 to
31877e2
Compare
JorTurFer
approved these changes
Mar 5, 2025
|
/run-e2e external |
zroubalik
approved these changes
Mar 6, 2025
gautierdelorme
added a commit
to gautierdelorme/keda-docs
that referenced
this pull request
Mar 6, 2025
Relates to kedacore/keda#6606 Signed-off-by: Gautier Delorme <gautier.delorme@gmail.com>
zroubalik
pushed a commit
to kedacore/keda-docs
that referenced
this pull request
Mar 6, 2025
Relates to kedacore/keda#6606 Signed-off-by: Gautier Delorme <gautier.delorme@gmail.com>
mittalvaibhav1
pushed a commit
to mittalvaibhav1/keda
that referenced
this pull request
Apr 26, 2025
Currently TLS is enabled only if the ScaledObject's trigger contains a custom CA certificate or enable client TLS. Else it does not use the default TLS config that includes CAs already loaded by the Operator. This is a problem if we have an external scaler presenting a TLS certificate that should be accepted by the Operator without requiring client TLS. To keep the change backward compatible I've added a new `enableTLS` parameter that can be set to `"true"` to enable TLS w/o client TLS or custom CA. The parameter name is consistent with other scalers (e.g. Metrics API, Redis, Kafka...). Signed-off-by: Gautier Delorme <gautier.delorme@gmail.com> Signed-off-by: mittalvaibhav1 <mittalvaibhavandroid@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently TLS is enabled only if the ScaledObject's trigger contains a custom CA certificate or enable client TLS. Else it does not use the default TLS config that includes CAs already loaded by the Operator. This is a problem if we have an external scaler presenting a TLS certificate that should be accepted by the Operator without requiring client TLS.
To keep the change backward compatible I've added a new
enableTLSparameter that can be set to"true"to enable TLS w/o client TLS or custom CA. The parameter name is consistent with other scalers (e.g. Metrics API, Redis, Kafka...).Checklist
Relates to kedacore/keda-docs#1547