-
Notifications
You must be signed in to change notification settings - Fork 1.2k
Fix grafana dashboard to handle wildcard scaledObject variables #6215
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
JorTurFer
merged 4 commits into
kedacore:main
from
alexkuretz:fix-grafana-wildcard-scaledObject
Oct 6, 2024
Merged
Fix grafana dashboard to handle wildcard scaledObject variables #6215
JorTurFer
merged 4 commits into
kedacore:main
from
alexkuretz:fix-grafana-wildcard-scaledObject
Oct 6, 2024
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Alex Kuretz <alex@andersonopt.com>
JorTurFer
reviewed
Oct 2, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Could you update the changelog with the issue? 🙏
Signed-off-by: Alex Kuretz <alex@andersonopt.com>
CHANGELOG updated |
JorTurFer
reviewed
Oct 6, 2024
Signed-off-by: Alex Kuretz <alex@andersonopt.com>
JorTurFer
approved these changes
Oct 6, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks a lot!
/skip-e2e |
JorTurFer
added a commit
to JorTurFer/keda
that referenced
this pull request
Oct 7, 2024
…core#6215) * Fix grafana dashboard to handle wildcard scaledObject variables Signed-off-by: Alex Kuretz <alex@andersonopt.com> * Update changelog Signed-off-by: Alex Kuretz <alex@andersonopt.com> * Fix changelog order to be alphabetical Signed-off-by: Alex Kuretz <alex@andersonopt.com> --------- Signed-off-by: Alex Kuretz <alex@andersonopt.com> Co-authored-by: Jorge Turrado Ferrero <Jorge_turrado@hotmail.es> Signed-off-by: Jorge Turrado <jorge.turrado@scrm.lidl>
rickbrouwer
pushed a commit
to rickbrouwer/keda
that referenced
this pull request
Oct 21, 2024
…core#6215) * Fix grafana dashboard to handle wildcard scaledObject variables Signed-off-by: Alex Kuretz <alex@andersonopt.com> * Update changelog Signed-off-by: Alex Kuretz <alex@andersonopt.com> * Fix changelog order to be alphabetical Signed-off-by: Alex Kuretz <alex@andersonopt.com> --------- Signed-off-by: Alex Kuretz <alex@andersonopt.com> Co-authored-by: Jorge Turrado Ferrero <Jorge_turrado@hotmail.es>
mpechner-akasa
pushed a commit
to nrichardson-akasa/keda
that referenced
this pull request
Nov 29, 2024
…core#6215) * Fix grafana dashboard to handle wildcard scaledObject variables Signed-off-by: Alex Kuretz <alex@andersonopt.com> * Update changelog Signed-off-by: Alex Kuretz <alex@andersonopt.com> * Fix changelog order to be alphabetical Signed-off-by: Alex Kuretz <alex@andersonopt.com> --------- Signed-off-by: Alex Kuretz <alex@andersonopt.com> Co-authored-by: Jorge Turrado Ferrero <Jorge_turrado@hotmail.es> Signed-off-by: michael pechner <mike.pechner@akasa.com>
chiragbhatia8
pushed a commit
to chiragbhatia8/keda
that referenced
this pull request
Jan 9, 2025
…core#6215) * Fix grafana dashboard to handle wildcard scaledObject variables Signed-off-by: Alex Kuretz <alex@andersonopt.com> * Update changelog Signed-off-by: Alex Kuretz <alex@andersonopt.com> * Fix changelog order to be alphabetical Signed-off-by: Alex Kuretz <alex@andersonopt.com> --------- Signed-off-by: Alex Kuretz <alex@andersonopt.com> Co-authored-by: Jorge Turrado Ferrero <Jorge_turrado@hotmail.es> Signed-off-by: Chirag Bhatia <chiragbhatia8@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Provide a description of what has been changed
Grafana dashboard now properly handles wildcard scaledObject variables in graphs
Checklist
Fixes #6214