Skip to content

Conversation

sbarnesthornton
Copy link
Contributor

@sbarnesthornton sbarnesthornton commented Aug 15, 2024

Adds a new scaler for beanstalkd queues (https://github.com/beanstalkd/beanstalkd). It scales based on the total job count of reserved and ready jobs by default, with the option to add delayed jobs as well.

Both unit tests and integration tests have been added.

Checklist

Fixes to #5901

Relates to #1454

@sbarnesthornton sbarnesthornton requested a review from a team as a code owner August 15, 2024 15:42
Sam Barnes-Thornton added 2 commits August 15, 2024 15:49
Signed-off-by: Sam Barnes-Thornton <sepbt@btinternet.com>

Adds a new scaler for beanstalkd queues, along with necessary tests.

Signed-off-by: Sam Barnes-Thornton <sbt@netcraft.com>
Signed-off by: Sam Barnes-Thornton <sepbt@btinternet.com>

Signed-off-by: Sam Barnes-Thornton <sbt@netcraft.com>
Signed-off-by: Sam Barnes-Thornton <sbt@netcraft.com>
Signed-off-by: Sam Barnes-Thornton <sbt@netcraft.com>
Sam Barnes-Thornton and others added 2 commits August 19, 2024 08:31
Signed-off-by: Sam Barnes-Thornton <sbt@netcraft.com>
@JorTurFer
Copy link
Member

JorTurFer commented Aug 21, 2024

/run-e2e beanstalkd
Update: You can check the progress here

Co-authored-by: Jorge Turrado Ferrero <Jorge_turrado@hotmail.es>
Signed-off-by: sbarnesthornton <56411235+sbarnesthornton@users.noreply.github.com>
Copy link
Member

@JorTurFer JorTurFer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good. Just a comment related with e2e test

Signed-off-by: Sam Barnes-Thornton <sbt@netcraft.com>
@JorTurFer
Copy link
Member

JorTurFer commented Sep 2, 2024

/run-e2e beanstalkd
Update: You can check the progress here

Co-authored-by: Jorge Turrado Ferrero <Jorge_turrado@hotmail.es>
Signed-off-by: sbarnesthornton <56411235+sbarnesthornton@users.noreply.github.com>
@JorTurFer
Copy link
Member

JorTurFer commented Oct 6, 2024

/run-e2e beanstalkd
Update: You can check the progress here

Copy link
Member

@JorTurFer JorTurFer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for the super slow response...

LGTM! Thanks for the scaler ❤️

PTAL @zroubalik @wozniakjan

@JorTurFer JorTurFer mentioned this pull request Nov 3, 2024
28 tasks
Copy link
Member

@zroubalik zroubalik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

Signed-off-by: Zbynek Roubalik <zroubalik@gmail.com>
@zroubalik zroubalik merged commit 2f66865 into kedacore:main Nov 5, 2024
15 of 16 checks passed
mpechner-akasa pushed a commit to nrichardson-akasa/keda that referenced this pull request Nov 29, 2024
Signed-off-by: Sam Barnes-Thornton <sbt@netcraft.com>
Signed-off-by: sbarnesthornton <56411235+sbarnesthornton@users.noreply.github.com>
Signed-off-by: Zbynek Roubalik <zroubalik@gmail.com>
Co-authored-by: Sam Barnes-Thornton <sbt@netcraft.com>
Co-authored-by: Jorge Turrado Ferrero <Jorge_turrado@hotmail.es>
Co-authored-by: Zbynek Roubalik <zroubalik@gmail.com>
Signed-off-by: michael pechner <mike.pechner@akasa.com>
chiragbhatia8 pushed a commit to chiragbhatia8/keda that referenced this pull request Jan 9, 2025
Signed-off-by: Sam Barnes-Thornton <sbt@netcraft.com>
Signed-off-by: sbarnesthornton <56411235+sbarnesthornton@users.noreply.github.com>
Signed-off-by: Zbynek Roubalik <zroubalik@gmail.com>
Co-authored-by: Sam Barnes-Thornton <sbt@netcraft.com>
Co-authored-by: Jorge Turrado Ferrero <Jorge_turrado@hotmail.es>
Co-authored-by: Zbynek Roubalik <zroubalik@gmail.com>
Signed-off-by: Chirag Bhatia <chiragbhatia8@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants