add sessionsPerNode and setSessionsFromHub parameters to selenium-grid scaler #6055
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 task
|
Could you open an issue and provide a description of your improvement for better tracking? |
SpiritZhou
reviewed
Aug 13, 2024
|
/run-e2e selenium |
|
@rubroboletus , there are 2 checks failing:
Could you take a look please? |
…d scaler, add tests and changelog Signed-off-by: Hanzlik, Robert (MONETA) <robert.hanzlik@moneta.cz>
Signed-off-by: Hanzlik, Robert (MONETA) <robert.hanzlik@moneta.cz>
Signed-off-by: Hanzlik, Robert (MONETA) <robert.hanzlik@moneta.cz>
Signed-off-by: Hanzlik, Robert (MONETA) <robert.hanzlik@moneta.cz>
Signed-off-by: Hanzlik, Robert (MONETA) <robert.hanzlik@moneta.cz>
Signed-off-by: Hanzlik, Robert (MONETA) <robert.hanzlik@moneta.cz>
Signed-off-by: Hanzlik, Robert (MONETA) <robert.hanzlik@moneta.cz>
Co-authored-by: Jorge Turrado Ferrero <Jorge_turrado@hotmail.es> Signed-off-by: Robert Hanzlík <robi@junyks.cz> Signed-off-by: Hanzlik, Robert (MONETA) <robert.hanzlik@moneta.cz>
55c5325 to
4e22dea
Compare
Signed-off-by: Hanzlik, Robert (MONETA) <robert.hanzlik@moneta.cz>
@JorTurFer Fixed. |
Wolfe1
approved these changes
Aug 20, 2024
|
/run-e2e selenium |
JorTurFer
approved these changes
Sep 2, 2024
|
@rubroboletus, can you review this PR #6169 to see it can solve your expectation. |
Problem is, that you can obtain info from the Grid only in case, that there is at least one node of such type running. When there is no node of such type running, you know nothing about its settings. |
|
Ok, I can understand now, the problem for calculation when minReplica=0. |
|
I updated one more scaler param |
Signed-off-by: Jorge Turrado Ferrero <Jorge_turrado@hotmail.es>
JorTurFer
approved these changes
Oct 16, 2024
rickbrouwer
pushed a commit
to rickbrouwer/keda
that referenced
this pull request
Oct 21, 2024
…d scaler (kedacore#6055) * add sessionsPerNode and setSessionsFromHub parameters to selenium-grid scaler, add tests and changelog Signed-off-by: Hanzlik, Robert (MONETA) <robert.hanzlik@moneta.cz> * fix tests Signed-off-by: Hanzlik, Robert (MONETA) <robert.hanzlik@moneta.cz> * fix json Signed-off-by: Hanzlik, Robert (MONETA) <robert.hanzlik@moneta.cz> * fix json Signed-off-by: Hanzlik, Robert (MONETA) <robert.hanzlik@moneta.cz> * fix tests Signed-off-by: Hanzlik, Robert (MONETA) <robert.hanzlik@moneta.cz> * fix metadata tests Signed-off-by: Hanzlik, Robert (MONETA) <robert.hanzlik@moneta.cz> * fix syntax Signed-off-by: Hanzlik, Robert (MONETA) <robert.hanzlik@moneta.cz> * link Issue to Changelog Signed-off-by: Hanzlik, Robert (MONETA) <robert.hanzlik@moneta.cz> * fix link to issue Signed-off-by: Hanzlik, Robert (MONETA) <robert.hanzlik@moneta.cz> * add sessionBrowserVersion and tests Signed-off-by: Hanzlik, Robert (MONETA) <robert.hanzlik@moneta.cz> * add metadata tests Signed-off-by: Hanzlik, Robert (MONETA) <robert.hanzlik@moneta.cz> * Update CHANGELOG.md Co-authored-by: Jorge Turrado Ferrero <Jorge_turrado@hotmail.es> Signed-off-by: Robert Hanzlík <robi@junyks.cz> Signed-off-by: Hanzlik, Robert (MONETA) <robert.hanzlik@moneta.cz> * make cyclomatic complexity smaller Signed-off-by: Hanzlik, Robert (MONETA) <robert.hanzlik@moneta.cz> --------- Signed-off-by: Hanzlik, Robert (MONETA) <robert.hanzlik@moneta.cz> Signed-off-by: Robert Hanzlík <robi@junyks.cz> Signed-off-by: Jorge Turrado Ferrero <Jorge_turrado@hotmail.es> Co-authored-by: Jorge Turrado Ferrero <Jorge_turrado@hotmail.es>
mpechner-akasa
pushed a commit
to nrichardson-akasa/keda
that referenced
this pull request
Nov 29, 2024
…d scaler (kedacore#6055) * add sessionsPerNode and setSessionsFromHub parameters to selenium-grid scaler, add tests and changelog Signed-off-by: Hanzlik, Robert (MONETA) <robert.hanzlik@moneta.cz> * fix tests Signed-off-by: Hanzlik, Robert (MONETA) <robert.hanzlik@moneta.cz> * fix json Signed-off-by: Hanzlik, Robert (MONETA) <robert.hanzlik@moneta.cz> * fix json Signed-off-by: Hanzlik, Robert (MONETA) <robert.hanzlik@moneta.cz> * fix tests Signed-off-by: Hanzlik, Robert (MONETA) <robert.hanzlik@moneta.cz> * fix metadata tests Signed-off-by: Hanzlik, Robert (MONETA) <robert.hanzlik@moneta.cz> * fix syntax Signed-off-by: Hanzlik, Robert (MONETA) <robert.hanzlik@moneta.cz> * link Issue to Changelog Signed-off-by: Hanzlik, Robert (MONETA) <robert.hanzlik@moneta.cz> * fix link to issue Signed-off-by: Hanzlik, Robert (MONETA) <robert.hanzlik@moneta.cz> * add sessionBrowserVersion and tests Signed-off-by: Hanzlik, Robert (MONETA) <robert.hanzlik@moneta.cz> * add metadata tests Signed-off-by: Hanzlik, Robert (MONETA) <robert.hanzlik@moneta.cz> * Update CHANGELOG.md Co-authored-by: Jorge Turrado Ferrero <Jorge_turrado@hotmail.es> Signed-off-by: Robert Hanzlík <robi@junyks.cz> Signed-off-by: Hanzlik, Robert (MONETA) <robert.hanzlik@moneta.cz> * make cyclomatic complexity smaller Signed-off-by: Hanzlik, Robert (MONETA) <robert.hanzlik@moneta.cz> --------- Signed-off-by: Hanzlik, Robert (MONETA) <robert.hanzlik@moneta.cz> Signed-off-by: Robert Hanzlík <robi@junyks.cz> Signed-off-by: Jorge Turrado Ferrero <Jorge_turrado@hotmail.es> Co-authored-by: Jorge Turrado Ferrero <Jorge_turrado@hotmail.es> Signed-off-by: michael pechner <mike.pechner@akasa.com>
chiragbhatia8
pushed a commit
to chiragbhatia8/keda
that referenced
this pull request
Jan 9, 2025
…d scaler (kedacore#6055) * add sessionsPerNode and setSessionsFromHub parameters to selenium-grid scaler, add tests and changelog Signed-off-by: Hanzlik, Robert (MONETA) <robert.hanzlik@moneta.cz> * fix tests Signed-off-by: Hanzlik, Robert (MONETA) <robert.hanzlik@moneta.cz> * fix json Signed-off-by: Hanzlik, Robert (MONETA) <robert.hanzlik@moneta.cz> * fix json Signed-off-by: Hanzlik, Robert (MONETA) <robert.hanzlik@moneta.cz> * fix tests Signed-off-by: Hanzlik, Robert (MONETA) <robert.hanzlik@moneta.cz> * fix metadata tests Signed-off-by: Hanzlik, Robert (MONETA) <robert.hanzlik@moneta.cz> * fix syntax Signed-off-by: Hanzlik, Robert (MONETA) <robert.hanzlik@moneta.cz> * link Issue to Changelog Signed-off-by: Hanzlik, Robert (MONETA) <robert.hanzlik@moneta.cz> * fix link to issue Signed-off-by: Hanzlik, Robert (MONETA) <robert.hanzlik@moneta.cz> * add sessionBrowserVersion and tests Signed-off-by: Hanzlik, Robert (MONETA) <robert.hanzlik@moneta.cz> * add metadata tests Signed-off-by: Hanzlik, Robert (MONETA) <robert.hanzlik@moneta.cz> * Update CHANGELOG.md Co-authored-by: Jorge Turrado Ferrero <Jorge_turrado@hotmail.es> Signed-off-by: Robert Hanzlík <robi@junyks.cz> Signed-off-by: Hanzlik, Robert (MONETA) <robert.hanzlik@moneta.cz> * make cyclomatic complexity smaller Signed-off-by: Hanzlik, Robert (MONETA) <robert.hanzlik@moneta.cz> --------- Signed-off-by: Hanzlik, Robert (MONETA) <robert.hanzlik@moneta.cz> Signed-off-by: Robert Hanzlík <robi@junyks.cz> Signed-off-by: Jorge Turrado Ferrero <Jorge_turrado@hotmail.es> Co-authored-by: Jorge Turrado Ferrero <Jorge_turrado@hotmail.es> Signed-off-by: Chirag Bhatia <chiragbhatia8@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added two new parameters for selenium-grid scaler, allowing to scale up based on real browser node sizing. When sesSessionsFromHub is set, KEDA will look for existing browser nodes with browserName, browserVersion and platformName same as scaledObject / scaledJob, get maxSessions and calculate how much nodes it needs. When no existing browser node matches, it uses sessionsPerNode value for calculation.
Checklist
Fixes #
Relates to #