remove unused leader election parameters of metrics adapter #5986
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: lanting.chiang <lanting.chiang@robinhood.com>
JorTurFer
approved these changes
Jul 29, 2024
|
/run-e2e internal |
|
/run-e2e internal |
JorTurFer
pushed a commit
to JorTurFer/keda
that referenced
this pull request
Oct 7, 2024
…#5986) Signed-off-by: lanting.chiang <lanting.chiang@robinhood.com> Signed-off-by: Jorge Turrado <jorge.turrado@scrm.lidl>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
keda metrics adapter doesn't actually use leader election, but the code reads in unused environment variables that configure leader election. This commit is to remove that.
Checklist
Relates to kedacore/keda-docs#1450, kedacore/keda-docs#1434