Skip to content

replace deprecated golang/gomock with uber/gomock #5446

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Feb 12, 2024
Merged

replace deprecated golang/gomock with uber/gomock #5446

merged 4 commits into from
Feb 12, 2024

Conversation

rahulii
Copy link
Contributor

@rahulii rahulii commented Jan 31, 2024 •
edited by zroubalik
Loading

Provide a description of what has been changed

Checklist

  • [N/A] When introducing a new scaler, I agree with the scaling governance policy
  • I have verified that my change is according to the deprecations & breaking changes policy
  • Tests have been added
  • Changelog has been updated and is aligned with our changelog requirements
  • [N/A] A PR is opened to update our Helm chart (repo) (if applicable, ie. when deployment manifests are modified)
  • [N/A] A PR is opened to update the documentation on (repo) (if applicable)
  • Commits are signed with Developer Certificate of Origin (DCO - learn more)

Fixes #5440

Relates to #

@rahulii rahulii requested a review from a team as a code owner January 31, 2024 07:33
dttung2905
dttung2905 reviewed Jan 31, 2024
View reviewed changes
@wozniakjan wozniakjan mentioned this pull request Feb 5, 2024
Merged
4 tasks
@zroubalik
Copy link
Member

zroubalik commented Feb 6, 2024 •
edited by github-actions bot
Loading

/run-e2e internal
Update: You can check the progress here

JorTurFer
JorTurFer reviewed Feb 6, 2024
View reviewed changes
Copy link
Member

@JorTurFer JorTurFer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! just small nit inline

@JorTurFer
Copy link
Member

Could you solve the changelog conflict?

@rahulii
replace deprecated gomock with uber's gomock
ac7c9e6 
Signed-off-by: rahulii <r.sawra@gmail.com>
@rahulii
move changelog to other
01f8a16 
Signed-off-by: rahulii <r.sawra@gmail.com>
@rahulii
remove golang/mock module as it is no longer used
ebb3733 
Signed-off-by: rahulii <r.sawra@gmail.com>
@rahulii
Copy link
Contributor Author

rahulii commented Feb 7, 2024

Could you solve the changelog conflict?

done!

@rahulii
correct order of changelog
7711f3c 
Signed-off-by: rahulii <r.sawra@gmail.com>
@rahulii rahulii requested a review from JorTurFer February 7, 2024 08:45
JorTurFer
JorTurFer approved these changes Feb 7, 2024
View reviewed changes
Copy link
Member

@JorTurFer JorTurFer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for the contribution ❤️

@JorTurFer
Copy link
Member

JorTurFer commented Feb 7, 2024 •
edited by github-actions bot
Loading

/run-e2e
Update: You can check the progress here

@JorTurFer
Copy link
Member

JorTurFer commented Feb 8, 2024 •
edited by github-actions bot
Loading

/run-e2e
Update: You can check the progress here

@JorTurFer
Copy link
Member

/run-e2e

Only us can trigger the e2e tests because they use real infra 😄

@JorTurFer
Copy link
Member

JorTurFer commented Feb 9, 2024 •
edited by github-actions bot
Loading

/run-e2e
Update: You can check the progress here

@zroubalik
Copy link
Member

zroubalik commented Feb 12, 2024 •
edited by github-actions bot
Loading

/run-e2e kafka
Update: You can check the progress here

@zroubalik zroubalik enabled auto-merge (squash) February 12, 2024 22:12
@zroubalik zroubalik merged commit deb0601 into kedacore:main Feb 12, 2024
ArunYogesh pushed a commit to ArunYogesh/keda that referenced this pull request Mar 1, 2024
@rahulii @ArunYogesh
replace deprecated golang/gomock with uber/gomock (kedacore#5446)
03bc335 
Signed-off-by: rahulii <r.sawra@gmail.com>
Signed-off-by: Arun Yogesh <6723526+ArunYogesh@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zroubalik zroubalik zroubalik approved these changes

@JorTurFer JorTurFer JorTurFer approved these changes

@dttung2905 dttung2905 Awaiting requested review from dttung2905

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Migrate away from unmaintained golang/mock
4 participants
@rahulii @zroubalik @JorTurFer @dttung2905