Skip to content

feat(aws-sqs): Support for scaling to include delayed messages #4900

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 25, 2023
Merged

feat(aws-sqs): Support for scaling to include delayed messages #4900

merged 1 commit into from
Aug 25, 2023

Conversation

phr3nzii
Copy link
Contributor

This pull request introduces an option to include delayed messages when calculating the message count with the AWS SQS scaler.

Checklist

Fixes #4377
Relates to and supersedes #4383
Documentation kedacore/keda-docs#1213

@phr3nzii phr3nzii requested a review from a team as a code owner August 23, 2023 14:54
@github-actions
Copy link

Thank you for your contribution! 🙏 We will review your PR as soon as possible.

🏖️ Over the summer, the response time will be longer than usual due to maintainers taking time off so please bear with us.

While you are waiting, make sure to:

Learn more about:

@phr3nzii phr3nzii force-pushed the sqs-delayed-scaling branch from a4a444c to a44e980 Compare August 23, 2023 14:58
@phr3nzii phr3nzii mentioned this pull request Aug 23, 2023
Closed
7 tasks
@phr3nzii phr3nzii force-pushed the sqs-delayed-scaling branch from a44e980 to a15a9b0 Compare August 23, 2023 15:23
@phr3nzii phr3nzii force-pushed the sqs-delayed-scaling branch from a15a9b0 to 9257800 Compare August 23, 2023 18:50
JorTurFer
JorTurFer approved these changes Aug 24, 2023
View reviewed changes
Copy link
Member

@JorTurFer JorTurFer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! ❤️

@JorTurFer
Copy link
Member

JorTurFer commented Aug 24, 2023 •
edited by github-actions bot
Loading

/run-e2e aws
Update: You can check the progress here

@JorTurFer JorTurFer merged commit d6a0840 into kedacore:main Aug 25, 2023
yoongon pushed a commit to yoongon/keda that referenced this pull request Aug 26, 2023
@phr3nzii @yoongon
feat(aws-sqs): Support for scaling to include delayed messages (kedac…
e4b63bb 
…ore#4900)

Signed-off-by: Yoon Park <yoongon.park@gmail.com>
novicr pushed a commit to novicr/keda that referenced this pull request Aug 26, 2023
@phr3nzii @novicher
feat(aws-sqs): Support for scaling to include delayed messages (kedac…
2a51fd4 
…ore#4900)
Adarsh-verma-14 pushed a commit to Adarsh-verma-14/keda that referenced this pull request Sep 4, 2023
@phr3nzii
feat(aws-sqs): Support for scaling to include delayed messages (kedac…
1ff885e 
…ore#4900)
toniiiik pushed a commit to toniiiik/keda that referenced this pull request Jan 15, 2024
@phr3nzii @toniiiik
feat(aws-sqs): Support for scaling to include delayed messages (kedac…
d3d515c 
…ore#4900)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JorTurFer JorTurFer JorTurFer approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

AWS sqs scaler to support scaleOnDelayed
2 participants
@phr3nzii @JorTurFer