Skip to content

feat(command): support passing additional arguments to the command #364

@kyu08

Description

@kyu08

Based on feedback from reddit.

TODO

  • Merge bump deps PRs
  • Break this feature development down into small tasks.
  • impl

Processing flow

flowchart TD
    A[Start] --> B{Check conditions}
    B -->|Condition 1: Ctrl+O is pressed| C[Waiting for input]
    B -->|Ctrl+O not pressed| D[Nothing happens]
    C -->|Condition 2: Command list<br>has one or more commands| E[Additional Arguments Window opens]
    C -->|Command list is empty| F[Nothing happens]
    E --> G{User action}
    G -->|Input text| H[Process input in<br>Additional Arguments Window]
    G -->|Press Enter| I[Execute command<br>Close Additional Arguments Window]
    G -->|Press Esc| J[Return to original screen<br>Close Additional Arguments Window]
    H --> G
Loading

Test cases

  • Additional arguments
    • All patterns of above flow can be executed.
  • History
    • Histories including additional arguments are read properly.
    • Histories including additional arguments are written properly.
  • Regression
    • Existing feature works properly.
      • History
        • Read histories
        • Write histories
      • Execution
        • Any command can be executed.
        • Narrow downed command can be executed.
      • Preview
        • Preview is shown properly.
  • Documents
    • README is updated if needed.

Metadata

Metadata

Assignees

Labels

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions