feat(command): support passing additional arguments to the command #447
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6cfdbd8 to
5880378
Compare
kyu08
commented
May 7, 2025
There was a problem hiding this comment.
Pull Request Overview
This PR introduces support for passing additional arguments to commands via a popup UI while refactoring command handling to use a new command type (CommandForExec).
- Integrates a popup window for entering extra arguments in the UI
- Updates command history, runner execution, and related test cases to use the new CommandForExec type
- Adjusts code throughout the codebase to seamlessly support the additional arguments feature
Reviewed Changes
Copilot reviewed 15 out of 17 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| src/usecase/tui/ui.rs | Adds popup window rendering and updates commands block layout |
| src/usecase/tui/app.rs | Updates key event handling and command history methods |
| src/usecase/repeat.rs | Adjusts command execution to use CommandForExec |
| src/model/* | Refactors command types and methods to use CommandForExec |
| README.md | Documents new feature for passing additional arguments |
Files not reviewed (2)
- test_data/just/justfile: Language not supported
- test_data/make/Makefile: Language not supported
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #364
What is "passing additional arguments"?
Ctrl + oto open additional arguments popup.Enterto execute the command.TODO
Test
/docs/MANUAL_TEST_CASES.md.fzf-makeescquits fzf-makeesccloses the popupfzf-make --repeatexecutes the command the last one.fzf-make --historylaunches fzf-make focusing history pane.