Skip to content

feat(orm): optimize orm cache #28

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Apr 10, 2024
Merged

feat(orm): optimize orm cache #28

merged 2 commits into from
Apr 10, 2024

Conversation

dongjiang1989
Copy link
Member

What type of PR is this?

/kind feature

  • Unittest
  • Coverage 80%+
  • Build Success

What this PR does / why we need it:

  1. Add support orm cache

@dongjiang1989
update golangci lint
4f3af87 
Signed-off-by: dongjiang1989 <dongjiang1989@126.com>
@pull-request-size pull-request-size bot added the size/L size/L label Apr 8, 2024
@the-label-bot the-label-bot bot added the kind/feature kind/feature label Apr 8, 2024
@the-label-bot The Label Bot
Copy link

the-label-bot bot commented Apr 8, 2024 •
edited
Loading

The Label Bot has predicted the following:

Category Value Confidence Applied Label
Kind feature 0.997 ✔️
Kind L 0.863 ✔️

@github-actions github-actions bot requested a review from imlense April 8, 2024 15:45
@codacy-production Codacy Production
Copy link

codacy-production bot commented Apr 8, 2024 •
edited
Loading

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation Diff coverage
✅ +0.00% (target: -1.00%) ✅ 90.91%
Coverage variation details
Coverable lines Covered lines Coverage
Common ancestor commit (3b913a3) 6818 6139 90.04%
Head commit (9f288e1) 6818 (+0) 6139 (+0) 90.04% (+0.00%)

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details
Coverable lines Covered lines Diff coverage
Pull request (#28) 11 10 90.91%

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings    Change summary preferences

You may notice some variations in coverage metrics with the latest Coverage engine update. For more details, visit the documentation

@dongjiang1989
fix cache arc bug
9f288e1 
Signed-off-by: dongjiang1989 <dongjiang1989@126.com>
@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented Apr 9, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
8.3% Duplication on New Code (required ≤ 3%)

See analysis details on SonarCloud

@dongjiang1989 dongjiang1989 changed the title feat(orm): Add support orm cache feat(orm): optimize orm cache Apr 10, 2024
@dongjiang1989 dongjiang1989 merged commit 6acd0f4 into main Apr 10, 2024
@dongjiang1989 dongjiang1989 deleted the add-gorm-cache branch February 17, 2025 03:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@imlense imlense Awaiting requested review from imlense

Assignees
No one assigned
Labels
kind/feature kind/feature size/L size/L
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@dongjiang1989