Skip to content

Refactors to kubectl CP command #80436

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jul 22, 2019
Merged

Refactors to kubectl CP command #80436

merged 2 commits into from
Jul 22, 2019

Conversation

M00nF1sh
Copy link
Contributor

@M00nF1sh M00nF1sh commented Jul 22, 2019 •
edited by tpepper
Loading

What type of PR is this?
/kind bug

What this PR does / why we need it:
clean up unused code and refactors.

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

Fix CVE-2019-11249: Incomplete fixes for CVE-2019-1002101 and CVE-2019-11246, kubectl cp potential directory traversal

@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-kind Indicates a PR lacks a `kind/foo` label and requires one. needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Jul 22, 2019
@M00nF1sh M00nF1sh changed the title Refactors to kubelet CP command Refactors to kubectl CP command Jul 22, 2019
@k8s-ci-robot k8s-ci-robot added area/kubectl sig/cli Categorizes an issue or PR as relevant to SIG CLI. and removed needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Jul 22, 2019
@M00nF1sh
Copy link
Contributor Author

/assign @tallclair

@tallclair
Copy link
Member

/kind bug
/priority important-soon

@k8s-ci-robot k8s-ci-robot added kind/bug Categorizes issue or PR as related to a bug. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. release-note-none Denotes a PR that doesn't merit a release note. and removed needs-kind Indicates a PR lacks a `kind/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Jul 22, 2019
@tallclair tallclair mentioned this pull request Jul 22, 2019
Closed
@M00nF1sh
Copy link
Contributor Author

/test pull-kubernetes-kubemark-e2e-gce-big

seans3
seans3 approved these changes Jul 22, 2019
View reviewed changes
Copy link
Contributor

@seans3 seans3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 22, 2019
@seans3
Copy link
Contributor

seans3 commented Jul 22, 2019

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: M00nF1sh, seans3

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 22, 2019
@k8s-ci-robot k8s-ci-robot merged commit 08f9f2b into kubernetes:master Jul 22, 2019
This was referenced Aug 1, 2019
Merged
Merged
Merged
k8s-ci-robot added a commit that referenced this pull request Aug 1, 2019
@k8s-ci-robot
Merge pull request #80869 from tallclair/automated-cherry-pick-of-#80…
f627830 
…436-upstream-release-1.15

Automated cherry pick of #80436: refactors to kubernetes CP command
k8s-ci-robot added a commit that referenced this pull request Aug 1, 2019
@k8s-ci-robot
Merge pull request #80871 from tallclair/automated-cherry-pick-of-#80…
3e4f6a9 
…436-upstream-release-1.13

Automated cherry pick of #80436: refactors to kubernetes CP command
k8s-ci-robot added a commit that referenced this pull request Aug 1, 2019
@k8s-ci-robot
Merge pull request #80870 from tallclair/automated-cherry-pick-of-#80…
0e9fcb4 
…436-upstream-release-1.14

Automated cherry pick of #80436: refactors to kubernetes CP command
@joelsmith joelsmith mentioned this pull request Aug 5, 2019
Closed
@joelsmith
Copy link
Contributor

We need to add the following release note:

Fix CVE-2019-11249: Incomplete fixes for CVE-2019-1002101 and CVE-2019-11246, kubectl cp potential directory traversal

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. and removed release-note-none Denotes a PR that doesn't merit a release note. labels Aug 5, 2019
@cji cji mentioned this pull request Aug 23, 2019
Open
@idealhack idealhack added this to the v1.16 milestone Sep 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@derekwaynecarr derekwaynecarr Awaiting requested review from derekwaynecarr

1 more reviewer

@seans3 seans3 seans3 approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees

@seans3 seans3

@tallclair tallclair

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/kubectl cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/cli Categorizes an issue or PR as relevant to SIG CLI. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
v1.16
Development

Successfully merging this pull request may close these issues.
6 participants
@M00nF1sh @tallclair @seans3 @k8s-ci-robot @joelsmith @idealhack