Skip to content

remove cfssl dependencies #84677

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Nov 4, 2019
Merged

remove cfssl dependencies #84677

merged 5 commits into from
Nov 4, 2019

Conversation

mikedanese
Copy link
Member

@mikedanese mikedanese commented Nov 2, 2019 •
edited
Loading

remove cfssl dependencies and add support for URI SANs.

/kind bug
/sig auth

Fixes #80057 in part

The certificate signer no longer accepts ca.key passwords via the CFSSL_CA_PK_PASSWORD environment variable. This capability was not prompted by user request, never advertised, and recommended against in the security audit.

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. kind/bug Categorizes issue or PR as related to a bug. sig/auth Categorizes an issue or PR as relevant to SIG Auth. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Nov 2, 2019
@mikedanese mikedanese self-assigned this Nov 2, 2019
@mikedanese mikedanese added priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. and removed needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Nov 2, 2019
@k8s-ci-robot k8s-ci-robot added area/apiserver area/cloudprovider area/dependency Issues or PRs related to dependency changes sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. sig/cloud-provider Categorizes an issue or PR as relevant to SIG Cloud Provider. sig/cluster-lifecycle Categorizes an issue or PR as relevant to SIG Cluster Lifecycle. labels Nov 2, 2019
@k8s-ci-robot k8s-ci-robot requested review from andrewsykim, caesarxuchao and a team November 2, 2019 17:02
@mikedanese mikedanese assigned liggitt and unassigned mikedanese Nov 2, 2019
mikedanese
mikedanese commented Nov 2, 2019
View reviewed changes
liggitt
liggitt reviewed Nov 2, 2019
View reviewed changes
@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Nov 2, 2019
@mikedanese mikedanese removed area/apiserver area/cloudprovider area/dependency Issues or PRs related to dependency changes sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. labels Nov 2, 2019
@k8s-ci-robot k8s-ci-robot added area/kubectl sig/cli Categorizes an issue or PR as relevant to SIG CLI. labels Nov 4, 2019
@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. and removed release-note-none Denotes a PR that doesn't merit a release note. labels Nov 4, 2019
@mikedanese mikedanese force-pushed the cfssl branch 2 times, most recently from 7419e7c to ad29a2a Compare November 4, 2019 16:42
@liggitt
Copy link
Member

liggitt commented Nov 4, 2019

one nit on godoc, then lgtm

@mikedanese mikedanese force-pushed the cfssl branch 2 times, most recently from aa53fd1 to 6f5e0ac Compare November 4, 2019 17:38
@liggitt
Copy link
Member

liggitt commented Nov 4, 2019

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 4, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: liggitt, mikedanese

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 4, 2019
@k8s-ci-robot
Copy link
Contributor

New changes are detected. LGTM label has been removed.

@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 4, 2019
@mikedanese mikedanese added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 4, 2019
@liggitt
Copy link
Member

liggitt commented Nov 4, 2019

/retest

@mikedanese mikedanese mentioned this pull request Nov 4, 2019
Merged
@k8s-ci-robot k8s-ci-robot merged commit aaa5707 into kubernetes:master Nov 4, 2019
@mikedanese mikedanese deleted the cfssl branch November 4, 2019 23:46
@cji cji mentioned this pull request Nov 10, 2019
Open
wking pushed a commit to wking/kubernetes that referenced this pull request Jul 21, 2020
@k8s-publishing-bot
Merge pull request kubernetes#84677 from mikedanese/cfssl
385e2fd 
remove cfssl dependencies

Kubernetes-commit: aaa5707
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@liggitt liggitt liggitt left review comments

@andrewsykim andrewsykim Awaiting requested review from andrewsykim

@caesarxuchao caesarxuchao Awaiting requested review from caesarxuchao

Assignees

@liggitt liggitt

@mikedanese mikedanese

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/dependency Issues or PRs related to dependency changes area/kubectl area/kubelet cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. sig/apps Categorizes an issue or PR as relevant to SIG Apps. sig/auth Categorizes an issue or PR as relevant to SIG Auth. sig/cli Categorizes an issue or PR as relevant to SIG CLI. sig/node Categorizes an issue or PR as relevant to SIG Node. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Milestone
v1.17
Development

Successfully merging this pull request may close these issues.

CertificateSigningRequest doesn't support URL SANs or isCA
4 participants
@mikedanese @liggitt @BenTheElder @k8s-ci-robot