Update docker-multinode instructions and version #18894

luxas · 2015-12-18T16:14:50Z

Update docker-multinode in the same manner as docker has been updated by @fgrzadkowski
Also run kube-proxy in a static pod on master and some formatting.

Related to #17981.
Partially depends on: #17213 (for serviceAccount functionality)

After this has been merged, we can go forward with supporting ARM images OOTB.

Assign to: @brendandburns
@dalanlan @fgrzadkowski @resouer

k8s-bot · 2015-12-18T16:15:14Z

Can one of the admins verify that this patch is reasonable to test? (reply "ok to test", or if you trust the user, reply "add to whitelist")

If this message is too spammy, please complain to ixdy.

k8s-bot · 2015-12-18T16:16:12Z

Can one of the admins verify that this patch is reasonable to test? (reply "ok to test", or if you trust the user, reply "add to whitelist")

If this message is too spammy, please complain to ixdy.

k8s-github-robot · 2015-12-18T16:22:33Z

Labelling this PR as size/L

brendandburns · 2015-12-18T22:13:00Z

docs/getting-started-guides/docker-multinode.md

@@ -39,7 +39,7 @@ interested in just starting to explore Kubernetes, we recommend that you start t

 _Note_:
 There is a [bug](https://github.com/docker/docker/issues/14106) in Docker 1.7.0 that prevents this from working correctly.


May as well just delete this and say: "expects Docker 1.8.x or higher..."

brendandburns · 2015-12-18T22:14:20Z

Some minor stuff, otherwise LGTM.

luxas · 2015-12-19T13:56:44Z

Ping @brendandburns

dalanlan · 2015-12-20T01:55:56Z

docs/getting-started-guides/docker-multinode.md

-1. You need a machine with docker of right version installed.
+The only thing you need is a machine with **Docker 1.8.x or higher**
+
+It might work with older docker versions, but that isn't supported.


I'm sorry but is this strictly required? I'm still working on docker 1.7.1 and it fits me well.
Maybe it's worth keeping the issue thing and also say something like "we prefer..., but..." :-)

@dalanlan Quite funny, I just edited it on request by @brendandburns

I think we should encourage users to use k8s with latest stable docker if possible.
Not everyone will use docker 1.8.x and higher, and as you say, 1.7.1 works well, so therefore I added that it might work with older versions

But I don't know how Kubernetes Docker policy is set up, if docker 1.7.1 is supported by k8s 1.1.x

AFAIU the bug referenced here affects users only if they run docker daemon differently. We don't do this in our guide. I'd either just delete this requirement at all, or move it to a separate section Troubleshooting. WDYT?

We do use docker daemon differently. The issue is about combining docker -d --bridge=none and docker run --net=host.

We do this for etcd and flannel, where they have --net=host and docker-bootstrap has --bridge=none.

I don't really know what to do to make everyone happy.
I assume @brendandburns wants docker >= 1.8.x because he said it, but should I make it like this?

It should work with older docker versions (like 1.7.1), but that isn't fully supported.

Good point :) Why not require version 1.7.1+?

@brendandburns Which version do you want to support?

Is the updated text OK?

Kubernetes itself doesn't require docker 1.8. If we know that this particular setup will not work with 1.7.0, then believe we should just write "1.7.1+".

Works fine for me

luxas · 2015-12-29T20:12:05Z

@brendandburns @fgrzadkowski @dalanlan Updated.
No dependency on sudo anymore and it's easy to specify which version one should use.
Required docker 1.7.1 or higher as we discussed.
Ready to merge?

luxas · 2016-01-02T19:09:29Z

Ping @brendandburns @fgrzadkowski
There are two pending PRs that more or less depends on this one.

brendandburns · 2016-01-04T19:16:40Z

docs/getting-started-guides/docker-multinode.md

@@ -74,10 +70,13 @@ This pattern is necessary because the `flannel` daemon is responsible for settin
 all of the Docker containers created by Kubernetes.  To achieve this, it must run outside of the _main_ Docker daemon.  However,
 it is still useful to use containers for deployment and management, so we create a simpler _bootstrap_ daemon to achieve this.

-You can specify k8s version on very node before install:
+You can specify the version on very node before install:


s/very/every/

brendandburns · 2016-01-04T19:18:31Z

Basically LGTM, one little nit.

luxas · 2016-01-04T21:58:38Z

Fixed

brendandburns · 2016-01-07T18:04:41Z

LGTM, you need to run ./hack/update-generated-docs.sh (sorry)

thanks
--brendan

k8s-github-robot · 2016-01-07T18:09:15Z

@k8s-bot ok to test
@k8s-bot test this

pr builder appears to be missing, activating due to 'lgtm' label.

k8s-bot · 2016-01-07T19:21:24Z

GCE e2e test build/test passed for commit 25dfd267bb2ed45ea6e5a5ed56e93999ec9e38d4.

luxas · 2016-01-08T21:07:54Z

@brendandburns @fgrzadkowski @wojtek-t @k8s-bot Unit test this please

gmarek · 2016-01-11T10:37:19Z

@luxas please run hack/update-generated-docs.sh

… in a pod in the docker-multnode manifest

k8s-github-robot · 2016-01-11T14:52:07Z

PR changed after LGTM, removing LGTM.

luxas · 2016-01-11T14:53:50Z

@gmarek @brendandburns I ran hack/update-generated-docs.sh now. It just added two empty lines.
OK to merge now?

gmarek · 2016-01-11T15:02:28Z

Let's wait for tests.

k8s-bot · 2016-01-11T15:25:31Z

GCE e2e test build/test passed for commit 7d49744.

k8s-github-robot · 2016-01-12T04:38:41Z

Automatic merge from submit-queue

Auto commit by PR queue bot

googlebot added the cla: yes label Dec 18, 2015

k8s-github-robot assigned brendandburns Dec 18, 2015

k8s-github-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Dec 18, 2015

luxas force-pushed the update_master_multi branch from b372ab6 to 8799c3c Compare December 18, 2015 19:30

brendandburns reviewed Dec 18, 2015
View reviewed changes

luxas force-pushed the update_master_multi branch from 8799c3c to d09aff5 Compare December 19, 2015 13:54

luxas mentioned this pull request Dec 19, 2015

Enable serviceaccounts for the docker-multinode deployment #17213

Merged

dalanlan reviewed Dec 20, 2015
View reviewed changes

luxas force-pushed the update_master_multi branch from d09aff5 to f75ca8e Compare December 26, 2015 18:16

This was referenced Dec 29, 2015

Similar project awassink/k8s-on-rpi#1

Open

Docs docker multi-node verify if services running before launching #19179

Closed

luxas force-pushed the update_master_multi branch from f75ca8e to 4cf4b9b Compare December 29, 2015 20:07

luxas mentioned this pull request Jan 1, 2016

in docs master.md, update docker command to run flanneld correctly #19212

Closed

brendandburns reviewed Jan 4, 2016
View reviewed changes

luxas force-pushed the update_master_multi branch from 4cf4b9b to 25dfd26 Compare January 4, 2016 21:56

luxas mentioned this pull request Jan 7, 2016

[Proposal] Make Kubernetes run on ARM devices #17981

Closed

17 tasks

brendandburns added lgtm "Looks good to me", indicates that a PR is ready to be merged. e2e-not-required labels Jan 7, 2016

Update docker-multinode instructions and version. Also run kube-proxy…

7d49744

… in a pod in the docker-multnode manifest

luxas force-pushed the update_master_multi branch from 25dfd26 to 7d49744 Compare January 11, 2016 14:51

k8s-github-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 11, 2016

gmarek added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 11, 2016

k8s-github-robot pushed a commit that referenced this pull request Jan 12, 2016

Merge pull request #18894 from luxas/update_master_multi

d246ed0

Auto commit by PR queue bot

k8s-github-robot merged commit d246ed0 into kubernetes:master Jan 12, 2016

		@@ -39,7 +39,7 @@ interested in just starting to explore Kubernetes, we recommend that you start t

		_Note_:
		There is a [bug](https://github.com/docker/docker/issues/14106) in Docker 1.7.0 that prevents this from working correctly.

Update docker-multinode instructions and version #18894

Update docker-multinode instructions and version #18894

Uh oh!

Conversation

luxas commented Dec 18, 2015

Uh oh!

k8s-bot commented Dec 18, 2015

Uh oh!

k8s-bot commented Dec 18, 2015

Uh oh!

k8s-github-robot commented Dec 18, 2015

Uh oh!

Choose a reason for hiding this comment

Uh oh!

brendandburns commented Dec 18, 2015

Uh oh!

luxas commented Dec 19, 2015

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

luxas commented Dec 29, 2015

Uh oh!

luxas commented Jan 2, 2016

Uh oh!

Choose a reason for hiding this comment

Uh oh!

brendandburns commented Jan 4, 2016

Uh oh!

luxas commented Jan 4, 2016

Uh oh!

brendandburns commented Jan 7, 2016

Uh oh!

k8s-github-robot commented Jan 7, 2016

Uh oh!

k8s-bot commented Jan 7, 2016

Uh oh!

luxas commented Jan 8, 2016

Uh oh!

gmarek commented Jan 11, 2016

Uh oh!

k8s-github-robot commented Jan 11, 2016

Uh oh!

luxas commented Jan 11, 2016

Uh oh!

gmarek commented Jan 11, 2016

Uh oh!

k8s-bot commented Jan 11, 2016

Uh oh!

k8s-github-robot commented Jan 12, 2016

Uh oh!

Uh oh!