Skip to content

Create flag api-server which allows for custom DNS setups #17459

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jun 29, 2025
Merged

Create flag api-server which allows for custom DNS setups #17459

merged 2 commits into from
Jun 29, 2025

Conversation

justinsb
Copy link
Member

Issue #17262

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jun 22, 2025
@justinsb justinsb force-pushed the justinsb/issue17262 branch from 2c95ae4 to aa88c92 Compare June 22, 2025 18:15
@justinsb
Copy link
Member Author

/hold so we can discuss a bit!

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jun 22, 2025
@justinsb justinsb mentioned this pull request Jun 22, 2025
Open
@hakman
Copy link
Member

hakman commented Jun 24, 2025

/retest

@justinsb justinsb force-pushed the justinsb/issue17262 branch from aa88c92 to 90066a5 Compare June 28, 2025 21:40
@hakman hakman changed the title Create flag override-api-endpoint which allows for custom DNS setups Create flag api-server which allows for custom DNS setups Jun 28, 2025
@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 28, 2025
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hakman

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 28, 2025
@hakman
Copy link
Member

hakman commented Jun 29, 2025

/hold so we can discuss a bit!

@justinsb anything left to do here?

@justinsb
Copy link
Member Author

I don't think there's anything left, we talked about this in office hours

/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jun 29, 2025
@k8s-ci-robot k8s-ci-robot merged commit 6d1ba3d into kubernetes:master Jun 29, 2025
25 checks passed
@k8s-ci-robot k8s-ci-robot added this to the v1.33 milestone Jun 29, 2025
@rifelpet rifelpet mentioned this pull request Jun 30, 2025
Merged
k8s-ci-robot added a commit that referenced this pull request Jun 30, 2025
@k8s-ci-robot
Merge pull request #17466 from rifelpet/automated-cherry-pick-of-#174…
6eafe14 
…59-origin-release-1.32

Automated cherry pick of #17459: Create flag api-server which allows for custom DNS setups
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hakman hakman hakman approved these changes

@johngmyers johngmyers Awaiting requested review from johngmyers

@olemarkus olemarkus Awaiting requested review from olemarkus

Assignees

@hakman hakman

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/documentation cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
v1.33
Development

Successfully merging this pull request may close these issues.
3 participants
@justinsb @hakman @k8s-ci-robot