Skip to content

Skip tests-e2e-scenarios-bare-metal when version.go changes #17391

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 21, 2025
Merged

Skip tests-e2e-scenarios-bare-metal when version.go changes #17391

merged 1 commit into from
Jun 21, 2025

Conversation

hakman
Copy link
Member

@hakman hakman commented May 4, 2025

/cc @rifelpet

@k8s-ci-robot k8s-ci-robot requested a review from rifelpet May 4, 2025 07:09
@linux-foundation-easycla Linux Foundation: EasyCLA
Copy link

linux-foundation-easycla bot commented May 4, 2025 •
edited
Loading

CLA Signed

The committers listed above are authorized under a signed CLA.

  • ✅ login: hakman / name: Ciprian Hacman (f0f02c4)

@k8s-ci-robot k8s-ci-robot added cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels May 4, 2025
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels May 4, 2025
@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels May 4, 2025
@hakman hakman force-pushed the skip-metal branch 5 times, most recently from 194082b to 86b6e0b Compare May 4, 2025 07:32
@k8s-ci-robot k8s-ci-robot added lgtm "Looks good to me", indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels May 4, 2025
@k8s-triage-robot
Copy link

The Kubernetes project has merge-blocking tests that are currently too flaky to consistently pass.

This bot retests PRs for certain kubernetes repos according to the following rules:

  • The PR does have any do-not-merge/* labels
  • The PR does not have the needs-ok-to-test label
  • The PR is mergeable (does not have a needs-rebase label)
  • The PR is approved (has cncf-cla: yes, lgtm, approved labels)
  • The PR is failing tests required for merge

You can:

/retest

@k8s-ci-robot k8s-ci-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. and removed lgtm "Looks good to me", indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels May 4, 2025
@hakman hakman force-pushed the skip-metal branch 3 times, most recently from 331c685 to a88f9ba Compare May 4, 2025 17:15
@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels May 4, 2025
@hakman
Copy link
Member Author

hakman commented May 5, 2025

/hold

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label May 5, 2025
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 21, 2025
@hakman hakman force-pushed the skip-metal branch 7 times, most recently from d75aa3d to 8bf575f Compare June 21, 2025 03:40
@hakman
Copy link
Member Author

hakman commented Jun 21, 2025

This is ready to merge now.
/unhold
/cc @rifelpet @ameukam

@k8s-ci-robot k8s-ci-robot requested a review from ameukam June 21, 2025 03:42
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jun 21, 2025
@k8s-ci-robot k8s-ci-robot requested a review from rifelpet June 21, 2025 03:42
@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 21, 2025
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: rifelpet

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 16174fe into kubernetes:master Jun 21, 2025
25 checks passed
@k8s-ci-robot k8s-ci-robot added this to the v1.32 milestone Jun 21, 2025
@hakman hakman deleted the skip-metal branch June 21, 2025 10:37
This was referenced Jun 22, 2025
Merged
Merged
k8s-ci-robot added a commit that referenced this pull request Jun 22, 2025
@k8s-ci-robot
Merge pull request #17455 from hakman/automated-cherry-pick-of-#17391…
eb4c4ad 
…-upstream-release-1.31

Automated cherry pick of #17391: Skip tests-e2e-scenarios-bare-metal when `version.go` changes
k8s-ci-robot added a commit that referenced this pull request Jun 22, 2025
@k8s-ci-robot
Merge pull request #17454 from hakman/automated-cherry-pick-of-#17391…
5ccd295 
…-upstream-release-1.32

Automated cherry pick of #17391: Skip tests-e2e-scenarios-bare-metal when `version.go` changes
@rifelpet rifelpet modified the milestones: v1.32, v1.33 Jun 23, 2025
@hakman hakman mentioned this pull request Aug 10, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rifelpet rifelpet rifelpet approved these changes

@ameukam ameukam Awaiting requested review from ameukam

Assignees

@rifelpet rifelpet

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
v1.33
Development

Successfully merging this pull request may close these issues.
4 participants
@hakman @k8s-triage-robot @k8s-ci-robot @rifelpet