Skip to content

Set MACAddressPolicy=none for Ubuntu 24.04 #17398

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 22, 2025
Merged

Set MACAddressPolicy=none for Ubuntu 24.04 #17398

merged 1 commit into from
May 22, 2025

Conversation

rifelpet
Copy link
Member

@rifelpet rifelpet commented May 8, 2025

known issues in the vpc cni project mention:

The workaround for this issue is to set MACAddressPolicy=none, as shown aws/amazon-vpc-cni-k8s#2103 (comment). This issue is known to affect Ubuntu 22.04+, and long-term solutions are being evaluated.

Kops was only setting this on 22.04, and we've seen similar pod connectivity issues with 24.04. So we'll try setting the same workaround for 24.04.

@k8s-ci-robot
Copy link
Contributor

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@k8s-ci-robot k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. area/nodeup labels May 8, 2025
@k8s-ci-robot k8s-ci-robot requested review from johngmyers and zetaab May 8, 2025 03:31
@rifelpet
Copy link
Member Author

rifelpet commented May 8, 2025

/test pull-kops-e2e-k8s-aws-amazonvpc

@rifelpet
Copy link
Member Author

rifelpet commented May 8, 2025

oops, that job uses AL2023

/test pull-kops-e2e-cni-amazonvpc

@rifelpet
Copy link
Member Author

rifelpet commented May 8, 2025

/test pull-kops-e2e-cni-amazonvpc

2 similar comments
@rifelpet
Copy link
Member Author

rifelpet commented May 8, 2025

/test pull-kops-e2e-cni-amazonvpc

@rifelpet
Copy link
Member Author

rifelpet commented May 9, 2025

/test pull-kops-e2e-cni-amazonvpc

@k8s-ci-robot
Copy link
Contributor

@rifelpet: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-kops-e2e-cni-amazonvpc d831560 link true /test pull-kops-e2e-cni-amazonvpc

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@k8s-ci-robot k8s-ci-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels May 22, 2025
@rifelpet rifelpet marked this pull request as ready for review May 22, 2025 14:30
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label May 22, 2025
@k8s-ci-robot k8s-ci-robot requested a review from olemarkus May 22, 2025 14:31
@rifelpet
Copy link
Member Author

/cc @hakman

@k8s-ci-robot k8s-ci-robot requested a review from hakman May 22, 2025 14:31
This was referenced May 22, 2025
Merged
Merged
@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 22, 2025
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hakman

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 22, 2025
k8s-ci-robot added a commit that referenced this pull request May 22, 2025
@k8s-ci-robot
Merge pull request #17414 from rifelpet/automated-cherry-pick-of-#173…
c1092be 
…98-origin-release-1.32

Automated cherry pick of #17398: Set MACAddressPolicy=none for Ubuntu 24.04
k8s-ci-robot added a commit that referenced this pull request May 22, 2025
@k8s-ci-robot
Merge pull request #17415 from rifelpet/automated-cherry-pick-of-#173…
8370110 
…98-origin-release-1.31

Automated cherry pick of #17398: Set MACAddressPolicy=none for Ubuntu 24.04
@k8s-ci-robot k8s-ci-robot merged commit ac053f9 into kubernetes:master May 22, 2025
25 checks passed
@k8s-ci-robot k8s-ci-robot added this to the v1.32 milestone May 22, 2025
@rifelpet rifelpet mentioned this pull request May 24, 2025
Merged
@rifelpet rifelpet modified the milestones: v1.32, v1.33 Jun 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hakman hakman hakman approved these changes

@johngmyers johngmyers Awaiting requested review from johngmyers

@zetaab zetaab Awaiting requested review from zetaab

@olemarkus olemarkus Awaiting requested review from olemarkus

Assignees

@hakman hakman

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/nodeup cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
v1.33
Development

Successfully merging this pull request may close these issues.
3 participants
@rifelpet @k8s-ci-robot @hakman