Skip to content

feat: Added cni-exclusive setting for cilium #17361

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Apr 23, 2025
Merged

feat: Added cni-exclusive setting for cilium #17361

merged 2 commits into from
Apr 23, 2025

Conversation

runitmisra
Copy link
Contributor

@runitmisra runitmisra commented Apr 21, 2025 •
edited
Loading

I have added the ability to set the cni-exclusive flag. It was hard-coded to be true before and it made it difficult to run service meshes like Istio(my usecase was to use ambient mode in istio which requires this flag to be false).

Here is the issue with more details: #17352

This is my first PR, please let me know if I have missed anything, I'll try my best to make this smooth for the maintainers. Thanks!

@k8s-ci-robot k8s-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Apr 21, 2025
@linux-foundation-easycla Linux Foundation: EasyCLA
Copy link

linux-foundation-easycla bot commented Apr 21, 2025 •
edited
Loading

CLA Signed

The committers listed above are authorized under a signed CLA.

@k8s-ci-robot k8s-ci-robot added area/addons cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. area/api area/documentation labels Apr 21, 2025
@k8s-ci-robot
Copy link
Contributor

Welcome @runitmisra!

It looks like this is your first PR to kubernetes/kops 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes/kops has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot k8s-ci-robot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Apr 21, 2025
@k8s-ci-robot
Copy link
Contributor

Hi @runitmisra. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels Apr 21, 2025
@runitmisra runitmisra changed the title [WIP] feat: Added cni-exclusive setting for cilium feat: Added cni-exclusive setting for cilium Apr 22, 2025
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Apr 22, 2025
hakman
hakman reviewed Apr 22, 2025
View reviewed changes
@hakman
Copy link
Member

hakman commented Apr 22, 2025

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Apr 22, 2025
@runitmisra @hakman
fix: review suggestions
38b3ee8 
Co-authored-by: Ciprian Hacman <ciprian@hakman.dev>
@hakman
Copy link
Member

hakman commented Apr 22, 2025

/retest

hakman
hakman approved these changes Apr 23, 2025
View reviewed changes
Copy link
Member

@hakman hakman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @runitmisra! 🙂

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 23, 2025
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hakman

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 23, 2025
@k8s-ci-robot k8s-ci-robot merged commit bca21c6 into kubernetes:master Apr 23, 2025
32 checks passed
@k8s-ci-robot k8s-ci-robot added this to the v1.32 milestone Apr 23, 2025
@hakman hakman mentioned this pull request Apr 23, 2025
Merged
@sanketnadkarni
Copy link

nice one @runitmisra <3

k8s-ci-robot added a commit that referenced this pull request Apr 23, 2025
@k8s-ci-robot
Merge pull request #17365 from hakman/automated-cherry-pick-of-#17361…
e0d42cd 
…-upstream-release-1.32

Automated cherry pick of #17361: feat: Added cni-exclusive setting for cilium
@hakman hakman mentioned this pull request Apr 27, 2025
Closed
@rifelpet rifelpet modified the milestones: v1.32, v1.33 Jun 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hakman hakman hakman approved these changes

@johngmyers johngmyers Awaiting requested review from johngmyers

Assignees

@hakman hakman

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/addons area/api area/documentation cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
v1.33
Development

Successfully merging this pull request may close these issues.
5 participants
@runitmisra @k8s-ci-robot @hakman @sanketnadkarni @rifelpet