Skip to content

Update etcd to v3.5.21 #17367

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Apr 25, 2025
Merged

Update etcd to v3.5.21 #17367

merged 2 commits into from
Apr 25, 2025

Conversation

hakman
Copy link
Member

@hakman hakman commented Apr 25, 2025

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Apr 25, 2025
@k8s-ci-robot k8s-ci-robot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Apr 25, 2025
@hakman
Copy link
Member Author

hakman commented Apr 25, 2025

/cc @rifelpet @ameukam

@ameukam
Copy link
Member

ameukam commented Apr 25, 2025

/retest

@hakman
Copy link
Member Author

hakman commented Apr 25, 2025

/test pull-kops-e2e-k8s-gce-cilium

@hakman
Copy link
Member Author

hakman commented Apr 25, 2025

/retest

@hakman
Copy link
Member Author

hakman commented Apr 25, 2025

Will need to bump the k8sVersion.Minor < 33 here:

kops/tests/e2e/pkg/tester/skip_regex.go

Lines 82 to 89 in 732397b

if k8sVersion.Minor < 33 {
// This seems to be specific to the kube-proxy replacement
// < 33 so we look at this again
skipRegex += "|Services.should.support.externalTrafficPolicy.Local.for.type.NodePort"
// https://github.com/kubernetes/kubernetes/issues/129221
// < 33 so we look at this again
skipRegex += "|Services.should.implement.NodePort.and.HealthCheckNodePort.correctly.when.ExternalTrafficPolicy.changes"
}

/override pull-kops-e2e-k8s-gce-cilium
/approve

@k8s-ci-robot
Copy link
Contributor

@hakman: Overrode contexts on behalf of hakman: pull-kops-e2e-k8s-gce-cilium

In response to this:

Will need to bump the k8sVersion.Minor < 33 here:

kops/tests/e2e/pkg/tester/skip_regex.go

Lines 82 to 89 in 732397b

if k8sVersion.Minor < 33 {
// This seems to be specific to the kube-proxy replacement
// < 33 so we look at this again
skipRegex += "|Services.should.support.externalTrafficPolicy.Local.for.type.NodePort"
// https://github.com/kubernetes/kubernetes/issues/129221
// < 33 so we look at this again
skipRegex += "|Services.should.implement.NodePort.and.HealthCheckNodePort.correctly.when.ExternalTrafficPolicy.changes"
}

/override pull-kops-e2e-k8s-gce-cilium
/approve

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hakman

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 25, 2025
@ameukam
Copy link
Member

ameukam commented Apr 25, 2025

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 25, 2025
@k8s-ci-robot k8s-ci-robot merged commit 377dc8d into kubernetes:master Apr 25, 2025
26 checks passed
@k8s-ci-robot k8s-ci-robot added this to the v1.32 milestone Apr 25, 2025
@hakman hakman deleted the etcd-3.5.21 branch April 25, 2025 14:23
This was referenced Apr 25, 2025
Merged
Merged
Merged
k8s-ci-robot added a commit that referenced this pull request Apr 25, 2025
@k8s-ci-robot
Merge pull request #17368 from hakman/automated-cherry-pick-of-#17367…
e9f7ed1 
…-upstream-release-1.32

Automated cherry pick of #17367: Update etcd to v3.5.21
k8s-ci-robot added a commit that referenced this pull request Apr 25, 2025
@k8s-ci-robot
Merge pull request #17370 from hakman/automated-cherry-pick-of-#17160-#…
7d22c12 
…17367-upstream-release-1.30

Automated cherry pick of #17160: Update etcd to v3.5.17
#17367: Update etcd to v3.5.21
k8s-ci-robot added a commit that referenced this pull request Apr 25, 2025
@k8s-ci-robot
Merge pull request #17369 from hakman/automated-cherry-pick-of-#17160-#…
be109e7 
…17367-upstream-release-1.31

Automated cherry pick of #17160: Update etcd to v3.5.17
#17367: Update etcd to v3.5.21
@rifelpet rifelpet modified the milestones: v1.32, v1.33 Jun 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@johngmyers johngmyers Awaiting requested review from johngmyers

@olemarkus olemarkus Awaiting requested review from olemarkus

@ameukam ameukam Awaiting requested review from ameukam

@rifelpet rifelpet Awaiting requested review from rifelpet

Assignees

@ameukam ameukam

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Milestone
v1.33
Development

Successfully merging this pull request may close these issues.
4 participants
@hakman @ameukam @k8s-ci-robot @rifelpet