add goaway-chance parameter for kube-apiserver #17357
Conversation
The committers listed above are authorized under a signed CLA. |
|
Hi @succa. Thanks for your PR. I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
afc1136 to
a34496a
Compare
| @@ -470,6 +470,8 @@ type KubeAPIServerConfig struct { | |||
| RequestheaderAllowedNames []string `json:"requestheaderAllowedNames,omitempty" flag:"requestheader-allowed-names"` | |||
| // FeatureGates is set of key=value pairs that describe feature gates for alpha/experimental features. | |||
| FeatureGates map[string]string `json:"featureGates,omitempty" flag:"feature-gates"` | |||
| // GoawayChance is the probability that send a GOAWAY to HTTP/2 clients. Default to 0, means never send GOAWAY. Max is 0.02 to prevent break the apiserver. | |||
| GoawayChance string `json:"goawayChance,omitempty" flag:"goaway-chance"` | |||
There was a problem hiding this comment.
This seems to be defined as float64:
https://github.com/kubernetes/kubernetes/blob/b53b9fb5573323484af9a19cf3f5bfe80760abba/staging/src/k8s.io/apiserver/pkg/server/config.go#L266
| GoawayChance string `json:"goawayChance,omitempty" flag:"goaway-chance"` | |
| GoawayChance float64 `json:"goawayChance,omitempty" flag:"goaway-chance"` |
There was a problem hiding this comment.
Correct, but controller-gen apparently does not like float64. When setting it, the output is
found float, the usage of which is highly discouraged, as support for them varies across languages. Please consider serializing your float as string instead. If you are really sure you want to use them, re-run with crd:allowDangerousTypes=true
Please suggest if the flag crd:allowDangerousTypes=true can be added
There was a problem hiding this comment.
Thanks for the explanation. One more Q, how far would you like this flag to be backported?
There was a problem hiding this comment.
I'm not sure about the question, following the docs I updated v1alpha2 and v1alpha3 as well. We are currently using v1alpha2, so ideally the flag should be present in all Cluster versions
|
/ok-to-test |
|
/retest |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: hakman The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/retest |
…-upstream-release-1.32 Automated cherry pick of #17357: add goaway-chance parameter for kube-apiserver
…-upstream-release-1.31 Automated cherry pick of #17357: add goaway-chance parameter for kube-apiserver
…-upstream-release-1.30 Automated cherry pick of #17357: add goaway-chance parameter for kube-apiserver
Add goaway-chance parameter for kube-apiserver
https://kubernetes.io/docs/reference/command-line-tools-reference/kube-apiserver/