Skip to content

gha: Introduce arm64 for tests #17286

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 25, 2025
Merged

gha: Introduce arm64 for tests #17286

merged 1 commit into from
Feb 25, 2025

Conversation

ameukam
Copy link
Member

@ameukam ameukam commented Feb 24, 2025

Introduce arm64 for Linux tests on Github Actions

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Feb 24, 2025
@ameukam
Copy link
Member Author

ameukam commented Feb 24, 2025

This is about verify (or always verify ?) a well-known and functional assumption toward arm64 (which we all know it's working thanks to Go toolchain)

cc @justinsb @hakman @rifelpet

@ameukam
Copy link
Member Author

ameukam commented Feb 24, 2025

Surprising we have prowjobs running for any change on .github/*

@justinsb
Copy link
Member

I think the "pending checks" are probably configured in GitHub branch protection. We can tweak those, but ... is it possible to influence the job names so that they match? (i.e. build-linux-amd64 and build-linux-arm64 ?). If not, we can change the checks configured in GitHub (and we'll probably have to change verify => verify-amd64 anyway)

@ameukam
Copy link
Member Author

ameukam commented Feb 24, 2025

I think the "pending checks" are probably configured in GitHub branch protection. We can tweak those, but ... is it possible to influence the job names so that they match? (i.e. build-linux-amd64 and build-linux-arm64 ?). If not, we can change the checks configured in GitHub (and we'll probably have to change verify => verify-amd64 anyway)

Do you mean something like name: verify - ${{ matrix.os }} ?

@justinsb
Copy link
Member

something like name: verify - ${{ matrix.os }} ?

If that works, yes - can we try?

@ameukam ameukam force-pushed the gha-matrix-os branch 4 times, most recently from 805dd9a to dc378e5 Compare February 24, 2025 18:05
@ameukam
gha: Introduce arm64 for tests
b42565e 
Introduce arm64 for Linux tests on Github Actions

Signed-off-by: Arnaud Meukam <ameukam@gmail.com>
@ameukam
Copy link
Member Author

ameukam commented Feb 24, 2025

@justinsb Looks like GHA let me do some customization. PTAL

@rifelpet
Copy link
Member

The PR is expecting a job named verify to pass, but we never run a job with that name. We'd need to update this before merging:

https://github.com/kubernetes/test-infra/blob/4be283a248ff85dda3a06928aafbe36deeb23e37/config/prow/config.yaml#L361-L368

ameukam added a commit to ameukam/test-infra that referenced this pull request Feb 24, 2025
@ameukam
prow: allow more contexts for kOps
a6fe136 
Add more contexts added in:
  - kubernetes/kops#17286

Signed-off-by: Arnaud Meukam <ameukam@gmail.com>
@ameukam ameukam mentioned this pull request Feb 24, 2025
Merged
@ameukam
Copy link
Member Author

ameukam commented Feb 24, 2025

Put this on hold to prevent accidental merge
/hold

We will remove the hold when it's approved and kubernetes/test-infra#34401 merged.

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Feb 24, 2025
@hakman hakman closed this Feb 25, 2025
@ameukam
Copy link
Member Author

ameukam commented Feb 25, 2025

/hold cancel

@hakman hakman reopened this Feb 25, 2025
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Feb 25, 2025
@hakman
Copy link
Member

hakman commented Feb 25, 2025

/override verify

@k8s-ci-robot
Copy link
Contributor

@hakman: Overrode contexts on behalf of hakman: verify

In response to this:

/override verify

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 25, 2025
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hakman

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 25, 2025
@ameukam
Copy link
Member Author

ameukam commented Feb 25, 2025

/test pull-kops-e2e-k8s-gce-ipalias

@hakman
Copy link
Member

hakman commented Feb 25, 2025

/override pull-kops-e2e-k8s-gce-cilium
/override pull-kops-e2e-k8s-gce-ipalias

@k8s-ci-robot
Copy link
Contributor

@hakman: Overrode contexts on behalf of hakman: pull-kops-e2e-k8s-gce-cilium, pull-kops-e2e-k8s-gce-ipalias

In response to this:

/override pull-kops-e2e-k8s-gce-cilium
/override pull-kops-e2e-k8s-gce-ipalias

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot merged commit 1f58f00 into kubernetes:master Feb 25, 2025
33 checks passed
@k8s-ci-robot k8s-ci-robot added this to the v1.32 milestone Feb 25, 2025
This was referenced Feb 25, 2025
Merged
Merged
Merged
k8s-ci-robot added a commit that referenced this pull request Feb 25, 2025
@k8s-ci-robot
Merge pull request #17291 from ameukam/automated-cherry-pick-of-#1728…
2001b62 
…6-origin-release-1.30

Automated cherry pick of #17286: gha: Introduce arm64 for tests
k8s-ci-robot added a commit that referenced this pull request Feb 25, 2025
@k8s-ci-robot
Merge pull request #17289 from ameukam/automated-cherry-pick-of-#1728…
b1be90e 
…6-origin-release-1.32

Automated cherry pick of #17286: gha: Introduce arm64 for tests
k8s-ci-robot added a commit that referenced this pull request Feb 25, 2025
@k8s-ci-robot
Merge pull request #17290 from ameukam/automated-cherry-pick-of-#1728…
b56e956 
…6-origin-release-1.31

Automated cherry pick of #17286: gha: Introduce arm64 for tests
@rifelpet rifelpet modified the milestones: v1.32, v1.33 Jun 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hakman hakman hakman approved these changes

@olemarkus olemarkus Awaiting requested review from olemarkus

Assignees

@hakman hakman

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
v1.33
Development

Successfully merging this pull request may close these issues.
5 participants
@ameukam @justinsb @rifelpet @hakman @k8s-ci-robot