Only set NTH ManagedASGTag label if it doesn't already exist #17141
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hakman
approved these changes
Dec 17, 2024
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: hakman The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added a commit
that referenced
this pull request
Dec 17, 2024
…41-origin-release-1.31 Automated cherry pick of #17141: Only set NTH ManagedASGTag label if it doesn't already exist
k8s-ci-robot
added a commit
that referenced
this pull request
Dec 17, 2024
…41-origin-release-1.30 Automated cherry pick of #17141: Only set NTH ManagedASGTag label if it doesn't already exist
|
/test all |
|
/retest |
|
/override pull-kops-e2e-k8s-aws-amazonvpc |
|
@hakman: Overrode contexts on behalf of hakman: pull-kops-e2e-k8s-aws-amazonvpc In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reported on slack.
If a cluster has ManagedASGTag set to an existing label, it is overwritten with an empty value. For the
kubernetes.io/cluster/$clustertag, this can cause problems during cluster deletion.NTH doesn't actually care about the value of the tag:
https://github.com/aws/aws-node-termination-handler/blob/a0c0aa1bd14780b0d5ca7ce70cd92eed746ff64d/pkg/monitor/sqsevent/sqs-monitor.go#L427-L431
So if the tag is already set then we should preserve its existing value.