fix: Get version from the BuildInfo.Main.Version if not found in deps and build flag #5846

dmvolod · 2025-01-16T09:17:10Z

k8s-ci-robot · 2025-01-16T09:17:20Z

Hi @dmvolod. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

k8s-ci-robot · 2025-01-16T09:17:21Z

Welcome @dmvolod!

It looks like this is your first PR to kubernetes-sigs/kustomize 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/kustomize has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

koba1t · 2025-01-17T14:23:41Z

Hi @dmvolod

Can you add any tests to check that this change didn't break current-version functions that will be set when the binary is released?

kustomize/releasing/create-release.sh

Lines 57 to 62 in 38eb244

    
                 CGO_ENABLED=0 GOOS=$os GOARCH=$arch go build -o output/$binary_name -ldflags\ 
        
                   "-s -w\ 
        
                   -X sigs.k8s.io/kustomize/api/provenance.version=$version\ 
        
                   -X sigs.k8s.io/kustomize/api/provenance.gitCommit=$(git rev-parse HEAD)\ 
        
                   -X sigs.k8s.io/kustomize/api/provenance.buildDate=$build_date"\ 
        
                   kustomize/main.go

dmvolod · 2025-01-18T12:32:27Z

Hi @dmvolod

Can you add any tests to check that this change didn't break current-version functions that will be set when the binary is released?

kustomize/releasing/create-release.sh

Lines 57 to 62 in 38eb244

CGO_ENABLED=0 GOOS=$os GOARCH=$arch go build -o output/$binary_name -ldflags\

"-s -w\

-X sigs.k8s.io/kustomize/api/provenance.version=$version\

-X sigs.k8s.io/kustomize/api/provenance.gitCommit=$(git rev-parse HEAD)\

-X sigs.k8s.io/kustomize/api/provenance.buildDate=$build_date"\

kustomize/main.go

Hi @koba1t

It's a good point, but unfortunately it seems to not be easy until this issue golang/go#33976 will be released (golang 1.24) and info.Main.Version not populated for test. Once this will be fixed, Version will be (devel).

I will try to rewrite function which will pass whole BuildInfo to be able to test it with mock data and not only Deps info.

… and build flag

dmvolod · 2025-01-29T09:13:55Z

api/provenance/provenance_test.go

 		Version: version,
 		Replace: nil,
 	}
 }

+func mockBuildInfo(mainVersion, depsVersion string) *debug.BuildInfo {


Hi @koba1t
Could you please review it.
Thanks in advance

Hi @koba1t
Any chance to get it reviewed and merged?
Thanks in advance,

Sorry for delay response.
I'll check.

koba1t · 2025-02-02T19:56:21Z

/ok-to-test

koba1t · 2025-03-28T13:21:53Z

/assign

k8s-triage-robot · 2025-06-26T13:24:49Z

The Kubernetes project currently lacks enough contributors to adequately respond to all PRs.

This bot triages PRs according to the following rules:

After 90d of inactivity, lifecycle/stale is applied
After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
After 30d of inactivity since lifecycle/rotten was applied, the PR is closed

You can:

Mark this PR as fresh with /remove-lifecycle stale
Close this PR with /close
Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

koba1t · 2025-06-26T21:28:41Z

So sorry to delay review.
Thanks for your contribution!

/lgtm
/approve

k8s-ci-robot · 2025-06-26T21:28:49Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dmvolod, koba1t

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [koba1t]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

This MR contains the following updates: | Package | Update | Change | |---|---|---| | [kubernetes-sigs/kustomize](https://github.com/kubernetes-sigs/kustomize) | minor | `v5.6.0` -> `v5.7.0` | MR created with the help of [el-capitano/tools/renovate-bot](https://gitlab.com/el-capitano/tools/renovate-bot). **Proposed changes to behavior should be submitted there as MRs.** --- ### Release Notes <details> <summary>kubernetes-sigs/kustomize (kubernetes-sigs/kustomize)</summary> ### [`v5.7.0`](https://github.com/kubernetes-sigs/kustomize/releases/tag/kustomize/v5.7.0) [Compare Source](kubernetes-sigs/kustomize@kustomize/v5.6.0...kustomize/v5.7.0) #### Feature kubernetes-sigs/kustomize#5630: Add static value source for replacement kubernetes-sigs/kustomize#5921: feat: Add images suport for Image Volumes kubernetes-sigs/kustomize#5771: fix: Allow patches with empty files with multiple newlines or comments kubernetes-sigs/kustomize#5865: feat(helm): allow the use of devel alias for helmcharts #### fix kubernetes-sigs/kustomize#5846: fix: Get version from the BuildInfo.Main.Version if not found in deps and build flag kubernetes-sigs/kustomize#5859: fix: Don't panic on multiple $patch: delete strategic merge patches in a single patch file kubernetes-sigs/kustomize#5877: fix: make private one field in replacements transformer struct that had a missing JSON tag #### Dependencies [#5847](kubernetes-sigs/kustomize#5847): replace deplecated package github.com/google/shlex with github.com/carapace-sh/carapace-shlex [#5873](kubernetes-sigs/kustomize#5873): Bump to github.com/spf13/viper v1.20.0 [#5931](kubernetes-sigs/kustomize#5931): Drop usage of forked copies of goyaml.v2 and goyaml.v3 #### chore kubernetes-sigs/kustomize#5882: Set Git messages to English for TestRemoteLoad\_LocalProtocol [#5934](kubernetes-sigs/kustomize#5934): Update kyaml to v0.20.0 [#5935](kubernetes-sigs/kustomize#5935): Update cmd/config to v0.20.0 [#5936](kubernetes-sigs/kustomize#5936): Update api to v0.20.0 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever MR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this MR and you won't be reminded about this update again. --- - [ ] If you want to rebase/retry this MR, check this box --- This MR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate).

k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jan 16, 2025

k8s-ci-robot requested review from koba1t and stormqueen1990 January 16, 2025 09:17

k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Jan 16, 2025

k8s-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Jan 16, 2025

fix: Get version from the BuildInfo.Main.Version if not found in deps…

9c68bd2

… and build flag

dmvolod force-pushed the issue-5845-fix-version branch from cd58781 to 9c68bd2 Compare January 19, 2025 06:25

k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jan 19, 2025

dmvolod mentioned this pull request Jan 24, 2025

REQUEST: New membership for dmvolod kubernetes/org#5372

Closed

11 tasks

dmvolod commented Jan 29, 2025

View reviewed changes

k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Feb 2, 2025

k8s-ci-robot assigned koba1t Mar 28, 2025

k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jun 26, 2025

k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 26, 2025

k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 26, 2025

k8s-ci-robot merged commit 03ae5c9 into kubernetes-sigs:master Jun 26, 2025
11 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

fix: Get version from the BuildInfo.Main.Version if not found in deps and build flag #5846

fix: Get version from the BuildInfo.Main.Version if not found in deps and build flag #5846

Uh oh!

dmvolod commented Jan 16, 2025

Uh oh!

k8s-ci-robot commented Jan 16, 2025

Uh oh!

k8s-ci-robot commented Jan 16, 2025

Uh oh!

koba1t commented Jan 17, 2025

Uh oh!

dmvolod commented Jan 18, 2025

Uh oh!

dmvolod Jan 29, 2025

Uh oh!

dmvolod Mar 10, 2025

Uh oh!

koba1t Mar 28, 2025

Uh oh!

koba1t commented Feb 2, 2025

Uh oh!

koba1t commented Mar 28, 2025

Uh oh!

k8s-triage-robot commented Jun 26, 2025

Uh oh!

koba1t commented Jun 26, 2025

Uh oh!

k8s-ci-robot commented Jun 26, 2025

Uh oh!

Uh oh!

Uh oh!

fix: Get version from the BuildInfo.Main.Version if not found in deps and build flag #5846

fix: Get version from the BuildInfo.Main.Version if not found in deps and build flag #5846

Uh oh!

Conversation

dmvolod commented Jan 16, 2025

Uh oh!

k8s-ci-robot commented Jan 16, 2025

Uh oh!

k8s-ci-robot commented Jan 16, 2025

Uh oh!

koba1t commented Jan 17, 2025

Uh oh!

dmvolod commented Jan 18, 2025

Uh oh!

dmvolod Jan 29, 2025

Choose a reason for hiding this comment

Uh oh!

dmvolod Mar 10, 2025

Choose a reason for hiding this comment

Uh oh!

koba1t Mar 28, 2025

Choose a reason for hiding this comment

Uh oh!

koba1t commented Feb 2, 2025

Uh oh!

koba1t commented Mar 28, 2025

Uh oh!

k8s-triage-robot commented Jun 26, 2025

Uh oh!

koba1t commented Jun 26, 2025

Uh oh!

k8s-ci-robot commented Jun 26, 2025

Uh oh!

Uh oh!

Uh oh!