fix: k8s api endpoint support domain #566
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: lixd <xueduan.li@gmail.com>
Codecov Report
📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more @@ Coverage Diff @@
## master #566 +/- ##
=======================================
Coverage 14.11% 14.11%
=======================================
Files 138 138
Lines 19394 19394
=======================================
Hits 2738 2738
Misses 16360 16360
Partials 296 296 |
|
/lgtm |
|
LGTM label has been added. Git tree hash: 8c79761fc36042950cd7479cc49efeee04432963
|
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: lixd, x893675 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Metrora
pushed a commit
to Metrora/kubeclipper
that referenced
this pull request
Mar 24, 2023
Signed-off-by: lixd <xueduan.li@gmail.com>
kubeclipper-bot
pushed a commit
that referenced
this pull request
Mar 28, 2023
* feat: update k8s apiserver cert SANs when update externalIP fix: k8s api endpoint support domain Signed-off-by: Liucw <liu.chuwei@99cloud.net> * fix: k8s api endpoint support domain (#566) Signed-off-by: lixd <xueduan.li@gmail.com> --------- Signed-off-by: Liucw <liu.chuwei@99cloud.net> Signed-off-by: lixd <xueduan.li@gmail.com> Co-authored-by: Liucw <liu.chuwei@99cloud.net> Co-authored-by: 意琦行 <31980412+lixd@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind feature
What this PR does / why we need it:
Which issue(s) this PR fixes:
Fixes #
Special notes for reviewers:
Does this PR introduced a user-facing change?
Additional documentation, usage docs, etc.: