fix: Set default rustls provider #1301
Conversation
Cargo.toml
Outdated
| @@ -51,6 +51,10 @@ hostname-validator = "1.1.1" | |||
| reqwest = { version = "0", default-features = false, features = [ | |||
| "rustls-tls-native-roots", | |||
| ] } | |||
| rustls = { version = "0.23", default-features = false, features = [ | |||
There was a problem hiding this comment.
Maybe it's better to re-export on policy-fetcher and consume it that way.
There was a problem hiding this comment.
Fine by me. One less dependency to keep on sync among our code.
tests/e2e.rs
Outdated
| .arg(&deployment_yaml); | ||
| cmd.assert().success(); | ||
|
|
||
| // Fail if deployment.yaml test data file was changed |
There was a problem hiding this comment.
test will fail until rebased on top of #1300.
There was a problem hiding this comment.
Let's wait to rebase it before merge it then.
There was a problem hiding this comment.
Rebased onto main, the e2e test was copied to the other PR and merged already.
tests/e2e.rs
Outdated
There was a problem hiding this comment.
ouch, I've already provided a e2e test for that inside of the other PR... I think we can drop this one
Cargo.toml
Outdated
| rustls = { version = "0.23", default-features = false, features = [ | ||
| "std", | ||
| "tls12", | ||
| ] } |
There was a problem hiding this comment.
| rustls = { version = "0.23", default-features = false, features = [ | |
| "std", | |
| "tls12", | |
| ] } | |
| # We will use the same version of rustls used by policy-fetcher | |
| rustls = { version = "0", default-features = false, features = [ | |
| "std", | |
| "tls12", | |
| ] } |
There was a problem hiding this comment.
Changing that inside of policy-fetcher and exporting it will be quite a pain. This should be enough.
756007d to
a5d7eec
Compare
Signed-off-by: Víctor Cuadrado Juan <vcuadradojuan@suse.de>
This fixes error on creating the resource catalog for the first time. Signed-off-by: Víctor Cuadrado Juan <vcuadradojuan@suse.de>
a5d7eec to
c9ce0c9
Compare
|
Rebased on top of main, after merging the other PR and the e2e test there. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1301 +/- ##
==========================================
+ Coverage 87.46% 87.47% +0.01%
==========================================
Files 34 34
Lines 4932 4936 +4
==========================================
+ Hits 4314 4318 +4
Misses 618 618 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Signed-off-by: Víctor Cuadrado Juan <vcuadradojuan@suse.de>
| @@ -51,6 +51,7 @@ hostname-validator = "1.1.1" | |||
| reqwest = { version = "0", default-features = false, features = [ | |||
| "rustls-tls-native-roots", | |||
| ] } | |||
| rustls = { version = "0.23", default-features = false } | |||
There was a problem hiding this comment.
Have you tried to relax that even more, like version = "0". This should avoid any complication with the next minor release of rustls
There was a problem hiding this comment.
I prefer to leave it as is, we will get the bot to bump anyways.
Description
Fix #1298
This fixes error on creating the resource catalog for the first time.
The rustls dependency is configured exactly as we do in policy-fetcher.
Test
Added new e2e test for
kwctl scaffold admission-request. Doubles as e2e test for #1300.Additional Information
Tradeoff
Potential improvement