fix: Use correct path for resource-catalog.json cache file #1300
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Víctor Cuadrado Juan <vcuadradojuan@suse.de>
Use `Path` instead of `PathBuf` to avoid useless `clone()` invocations. Signed-off-by: Flavio Castelli <fcastelli@suse.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1300 +/- ##
==========================================
+ Coverage 86.69% 87.46% +0.77%
==========================================
Files 34 34
Lines 4939 4932 -7
==========================================
+ Hits 4282 4314 +32
+ Misses 657 618 -39 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
viccuad
added a commit
to viccuad/kwctl
that referenced
this pull request
Aug 4, 2025
This test case doubles as checking for not overwriting the `--object` file see kubewarden#1300 Signed-off-by: Víctor Cuadrado Juan <vcuadradojuan@suse.de>
jvanz
approved these changes
Aug 4, 2025
|
wait a second, I'm coming up with a unit test |
flavio
approved these changes
Aug 4, 2025
jvanz
approved these changes
Aug 4, 2025
flavio
pushed a commit
to viccuad/kwctl
that referenced
this pull request
Aug 5, 2025
This test case doubles as checking for not overwriting the `--object` file see kubewarden#1300 Signed-off-by: Víctor Cuadrado Juan <vcuadradojuan@suse.de>
|
I did a forced push because I forgot to add the fixture file used by the tests 🤦 |
|
Ignore me, I pushed to the wrong branch. Tests are running now |
Avoid regressions of kubewarden#1299 Signed-off-by: Flavio Castelli <fcastelli@suse.com>
d3c8e29 to
af0963c
Compare
flavio
pushed a commit
to viccuad/kwctl
that referenced
this pull request
Aug 5, 2025
This test case doubles as checking for not overwriting the `--object` file see kubewarden#1300 Signed-off-by: Víctor Cuadrado Juan <vcuadradojuan@suse.de>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fix #1299
Test
No need for new tests. Would be to add a test here, but we are already checking for the error, no need to check that we aren't overwriting the incorrect file:
https://github.com/kubewarden/kwctl/blob/main/src/scaffold/admission_request.rs#L771
Additional Information
Tradeoff
Potential improvement