fix: correct checksum flag assignment and add checksum validation #128
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Code Metrics Report
Details | | main (065bc93) | #128 (5ff7504) | +/- |
|---------------------|----------------|----------------|-------|
+ | Coverage | 52.2% | 53.0% | +0.7% |
| Files | 5 | 5 | 0 |
| Lines | 442 | 443 | +1 |
+ | Covered | 231 | 235 | +4 |
+ | Code to Test Ratio | 1:0.4 | 1:0.4 | +0.0 |
| Code | 643 | 645 | +2 |
+ | Test | 259 | 260 | +1 |
| Test Execution Time | 36s | 36s | 0s |Code coverage of files in pull request scope (37.1% → 38.4%)
Reported by octocov |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request introduces changes to the handling of checksums in the
ghpackage, including the addition of checksum verification for release assets and the removal of redundant checksum code from thesetuppackage. The most important changes include the addition of a new checksum function, modifications to theAssetOptionstruct, and updates to the tests to cover the new checksum functionality.Checksum verification:
GetReleaseAssetfunction to validate the integrity of downloaded assets. (gh/gh.go, gh/gh.goR86-R92)checksumfunction to handle various checksum algorithms and formats. (gh/gh.go, gh/gh.goR291-R349)Struct and flag updates:
Checksumfield to theAssetOptionstruct to store the checksum value for verification. (gh/gh.go, gh/gh.goR66)rootCmdflags to use the correctChecksumfield from theoptstruct. (cmd/root.go, cmd/root.goL120-R120)Test enhancements:
gh/gh_test.go, gh/gh_test.goR50-R236)Checksumfield in theAssetOptionstruct. (gh/gh_test.go, gh/gh_test.goL25-R29)Code cleanup:
setuppackage, as it is now handled in theghpackage. (setup/setup.go, [1] [2] [3] [4]setuppackage. (setup/setup_test.go, setup/setup_test.goL34-L220)