feat: add checksum verification for assets #125
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Code Metrics Report
Details | | main (e443730) | #125 (d8ef600) | +/- |
|---------------------|----------------|----------------|-------|
+ | Coverage | 49.1% | 52.2% | +3.1% |
| Files | 5 | 5 | 0 |
| Lines | 407 | 442 | +35 |
+ | Covered | 200 | 231 | +31 |
+ | Code to Test Ratio | 1:0.1 | 1:0.4 | +0.2 |
| Code | 581 | 643 | +62 |
+ | Test | 103 | 259 | +156 |
- | Test Execution Time | 35s | 37s | +2s |Code coverage of files in pull request scope (48.6% → 52.9%)
Reported by octocov |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request introduces a new feature to support checksum verification for assets. The changes span across multiple files to integrate this functionality into the setup process. The most important changes include updates to the
README.mdandaction.ymlfiles to document and handle the newchecksuminput, modifications to thesetup.gofile to implement checksum verification, and the addition of tests to ensure the correctness of the checksum feature.Documentation and Input Handling:
README.md: Addedchecksumas a new input parameter and updated the example usage to include the checksum field. [1] [2] [3]action.yml: Introduced thechecksuminput parameter with a description and default value. [1] [2]Code Implementation:
setup/setup.go: Added imports for various hashing algorithms, included a newChecksumfield in theOptionstruct, and implemented thechecksumfunction to verify the checksum of the asset. [1] [2] [3] [4]Command Line Integration:
cmd/root.go: Added a new flag for thechecksumparameter to the command line interface.scripts/run-gh-setup.sh: Updated the script to pass the checksum parameter to the setup command. [1] [2]Testing:
setup/setup_test.go: Added comprehensive tests for the checksum verification function, covering various algorithms and edge cases.