fix: improve delimiter escaping for double-quoted strings #75
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Code Metrics Report
Details | | main (5c395c5) | #75 (3b9cfaa) | +/- |
|---------------------|----------------|---------------|-------|
+ | Coverage | 84.0% | 84.8% | +0.8% |
| Files | 3 | 3 | 0 |
| Lines | 232 | 245 | +13 |
+ | Covered | 195 | 208 | +13 |
+ | Code to Test Ratio | 1:1.7 | 1:1.8 | +0.0 |
| Code | 425 | 443 | +18 |
+ | Test | 764 | 807 | +43 |
- | Test Execution Time | - | 34s | +34s |Code coverage of files in pull request scope (93.1% → 94.0%)
Reported by octocov |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request introduces enhancements to the YAML interpolation and delimiter unescaping logic, along with expanded test coverage. The changes aim to improve handling of escaped delimiters and double-quoted strings, ensuring more robust functionality.
Enhancements to delimiter handling:
func unescapeDelimsinrepfn.goto detect and handle double-quoted strings heuristically. Adjusted the escaping logic to account for double quotes by adding extra backslashes when necessary.Improvements to interpolation function:
func ExprRepFninrepfn.goto use named return values for better readability and consistency.Expanded test coverage:
func TestReplaceYAMLWithExprRepFninexpand_test.goto validate interpolation and escaping behavior for various YAML scenarios, including nested maps, multiline strings, and JSON-like structures.